starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
This commit is contained in:
Gerrit User 14675 2024-05-07 13:16:54 +00:00 committed by Gerrit Code Review
parent 79fe7191a5
commit cc5aba116c
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5254bc4625d93ca9afe58f9671feec7815765c31
View File

@ -16,6 +16,24 @@
"message": "Since this is a path parameter I think it\u0027s worth validating if it exists so it exits before the API call, like how we do with the install/bootstrap/config values during subcloud add:\n\nhttps://opendev.org/starlingx/distcloud-client/src/branch/master/distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py#L277",
"revId": "5254bc4625d93ca9afe58f9671feec7815765c31",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "47afa97e_dd6e7fd5",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/sw_patch_manager.py",
"patchSetId": 2
},
"lineNbr": 78,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T13:16:54Z",
"side": 1,
"message": "I am already doing that here: https://review.opendev.org/c/starlingx/distcloud/+/917793/1/distributedcloud/dcmanager/orchestrator/states/patch/updating_patches.py#43 and since the API can work without the client, I think it\u0027s better to leave the validation there.",
"parentUuid": "94d82635_bdbd744c",
"revId": "5254bc4625d93ca9afe58f9671feec7815765c31",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}