Update patch set 9
Patch Set 9: (5 comments) Patch-set: 9 Attention: {"person_ident":"Gerrit User 31954 \u003c31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
This commit is contained in:
parent
577c35e34e
commit
025f6ca262
|
@ -0,0 +1,107 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7e43ab12_9a98d3ab",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 28,
|
||||
"author": {
|
||||
"id": 31954
|
||||
},
|
||||
"writtenOn": "2024-05-13T21:03:23Z",
|
||||
"side": 1,
|
||||
"message": "I assume we only need the install values and bootstrap values(for oam network configuration), can you help to understand what deployment config is expected here?",
|
||||
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "5569b95e_846c9962",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 53,
|
||||
"author": {
|
||||
"id": 31954
|
||||
},
|
||||
"writtenOn": "2024-05-13T21:03:23Z",
|
||||
"side": 1,
|
||||
"message": "Please set up dependencies with https://review.opendev.org/c/starlingx/utilities/+/917149",
|
||||
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c97851ac_1a40cb0b",
|
||||
"filename": "distributedcloud/dccommon/subcloud_enrollment.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 15,
|
||||
"author": {
|
||||
"id": 31954
|
||||
},
|
||||
"writtenOn": "2024-05-13T21:03:23Z",
|
||||
"side": 1,
|
||||
"message": "Suggest to use SPDX format instead:\n\nSPDX-License-Identifier: Apache-2.0",
|
||||
"range": {
|
||||
"startLine": 1,
|
||||
"startChar": 0,
|
||||
"endLine": 15,
|
||||
"endChar": 0
|
||||
},
|
||||
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f8e60f5b_b3444d01",
|
||||
"filename": "distributedcloud/dccommon/subcloud_enrollment.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 31954
|
||||
},
|
||||
"writtenOn": "2024-05-13T21:03:23Z",
|
||||
"side": 1,
|
||||
"message": "Maybe SubcloudEnrollInit? Enrollment is not finished by this class, please update the description as well",
|
||||
"range": {
|
||||
"startLine": 33,
|
||||
"startChar": 6,
|
||||
"endLine": 33,
|
||||
"endChar": 24
|
||||
},
|
||||
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "a85654d4_95477acf",
|
||||
"filename": "distributedcloud/dccommon/subcloud_enrollment.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 77,
|
||||
"author": {
|
||||
"id": 31954
|
||||
},
|
||||
"writtenOn": "2024-05-13T21:03:23Z",
|
||||
"side": 1,
|
||||
"message": "Is that the password expected to be updated for sysadmin_password?",
|
||||
"range": {
|
||||
"startLine": 77,
|
||||
"startChar": 24,
|
||||
"endLine": 77,
|
||||
"endChar": 38
|
||||
},
|
||||
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue