starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
This commit is contained in:
Gerrit User 36476 2024-05-10 20:56:55 +00:00 committed by Gerrit Code Review
parent 190d29da11
commit 220c58dff5
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
6d4ae16e9284d4b1e39d8b1e8c0bb20504aeabdb Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "b6010152_dd6d6358",
"filename": "distributedcloud/dccommon/drivers/openstack/software_v1.py",
"patchSetId": 4
},
"lineNbr": 52,
"author": {
"id": 36476
},
"writtenOn": "2024-05-10T20:56:55Z",
"side": 1,
"message": "Since the headers is always the same, why don\u0027t you move it to init?",
"range": {
"startLine": 52,
"startChar": 0,
"endLine": 52,
"endChar": 46
},
"revId": "6d4ae16e9284d4b1e39d8b1e8c0bb20504aeabdb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fa43b306_0f99268b",
"filename": "distributedcloud/dccommon/drivers/openstack/software_v1.py",
"patchSetId": 4
},
"lineNbr": 66,
"author": {
"id": 36476
},
"writtenOn": "2024-05-10T20:56:55Z",
"side": 1,
"message": "Also, remember to use f-string consistently",
"range": {
"startLine": 66,
"startChar": 0,
"endLine": 66,
"endChar": 79
},
"revId": "6d4ae16e9284d4b1e39d8b1e8c0bb20504aeabdb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fa40145b_1e36116b",
"filename": "distributedcloud/dccommon/drivers/openstack/software_v1.py",
"patchSetId": 4
},
"lineNbr": 83,
"author": {
"id": 36476
},
"writtenOn": "2024-05-10T20:56:55Z",
"side": 1,
"message": "This structure is duplicated in the methods. You could create a handler to perform these operations seamlessly",
"range": {
"startLine": 76,
"startChar": 0,
"endLine": 83,
"endChar": 19
},
"revId": "6d4ae16e9284d4b1e39d8b1e8c0bb20504aeabdb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d26463e4_a84f5b0b",
"filename": "distributedcloud/dccommon/tests/unit/drivers/test_software_v1.py",
"patchSetId": 4
},
"lineNbr": 2,
"author": {
"id": 36476
},
"writtenOn": "2024-05-10T20:56:55Z",
"side": 1,
"message": "Update",
"revId": "6d4ae16e9284d4b1e39d8b1e8c0bb20504aeabdb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}