diff --git a/1c9d6d294eef8fa09590fb7a78026f286ac99479 b/1c9d6d294eef8fa09590fb7a78026f286ac99479 new file mode 100644 index 000000000..58bf46861 --- /dev/null +++ b/1c9d6d294eef8fa09590fb7a78026f286ac99479 @@ -0,0 +1,554 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "9c65d844_f75fc90d", + "filename": "distributedcloud/dcorch/api/controllers/v1/subcloud_manager.py", + "patchSetId": 4 + }, + "lineNbr": 2, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "We should only add the years where we applied changes to the file. Was it modified since 2017?", + "range": { + "startLine": 2, + "startChar": 20, + "endLine": 2, + "endChar": 21 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "81cf8a1a_812d5d27", + "filename": "distributedcloud/dcorch/cmd/engine_worker.py", + "patchSetId": 4 + }, + "lineNbr": 15, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "In new files, we should opt for:\n```\n#\n# Copyright (c) 2024 Wind River Systems, Inc.\n#\n# SPDX-License-Identifier: Apache-2.0\n#\n```", + "range": { + "startLine": 2, + "startChar": 0, + "endLine": 15, + "endChar": 23 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "d43aeda7_1b2758b2", + "filename": "distributedcloud/dcorch/common/consts.py", + "patchSetId": 4 + }, + "lineNbr": 2, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "```\n# Copyright (c) 2017-2022, 2024 Wind River Systems, Inc.\n```", + "range": { + "startLine": 2, + "startChar": 0, + "endLine": 2, + "endChar": 50 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "f7df3254_d074994d", + "filename": "distributedcloud/dcorch/db/api.py", + "patchSetId": 4 + }, + "lineNbr": 16, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "This should be:\n\n```\n#\n# Copyright (c) 2024 Wind River Systems, Inc.\n#\n# SPDX-License-Identifier: Apache-2.0\n#\n```\n\nAlso, make sure the range correct. If the file wasn\u0027t modified since 2020, it should only contain the years in which it was changed.", + "range": { + "startLine": 16, + "startChar": 0, + "endLine": 16, + "endChar": 50 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "903822b4_a73270e5", + "filename": "distributedcloud/dcorch/db/sqlalchemy/api.py", + "patchSetId": 4 + }, + "lineNbr": 2, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "```\n# Copyright (c) 2017-2021, 2024 Wind River Systems, Inc.\n```", + "range": { + "startLine": 2, + "startChar": 0, + "endLine": 2, + "endChar": 50 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "3a6394cc_a631e8d5", + "filename": "distributedcloud/dcorch/db/sqlalchemy/migrate_repo/versions/008_delete_sync_lock.py", + "patchSetId": 4 + }, + "lineNbr": 12, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Update to:\n```\n#\n# Copyright (c) 2024 Wind River Systems, Inc.\n#\n# SPDX-License-Identifier: Apache-2.0\n#\n```", + "range": { + "startLine": 1, + "startChar": 0, + "endLine": 12, + "endChar": 20 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "37c75fad_09543780", + "filename": "distributedcloud/dcorch/db/sqlalchemy/models.py", + "patchSetId": 4 + }, + "lineNbr": 2, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "```\n# Copyright (c) 2017-2022, 2024 Wind River Systems, Inc.\n```", + "range": { + "startLine": 2, + "startChar": 0, + "endLine": 2, + "endChar": 50 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "39d02525_7f5cc04f", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 14, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "```\n#\n# Copyright (c) 2024 Wind River Systems, Inc.\n#\n# SPDX-License-Identifier: Apache-2.0\n#\n```", + "range": { + "startLine": 1, + "startChar": 0, + "endLine": 14, + "endChar": 32 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "24251122_21114df3", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 70, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Use f-string. The same applies to the messages below", + "range": { + "startLine": 69, + "startChar": 26, + "endLine": 70, + "endChar": 71 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "df441c37_c7253d5d", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 180, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Can\u0027t these conditionals below be grouped? For example, line 180 and 181 could be a single validation", + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "aecf4472_26fa9e1e", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 224, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "```\nreturn sc.availability_status \u003d\u003d dccommon_consts.AVAILABILITY_ONLINE and sc.initial_sync_state \u003d\u003d dco_consts.INITIAL_SYNC_STATE_COMPLETED\n```", + "range": { + "startLine": 220, + "startChar": 7, + "endLine": 224, + "endChar": 24 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "d369fdd0_f0cbccc9", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 271, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Shouldn\u0027t this be logged?", + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "6ea96f64_5d3133dd", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 305, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Same question about the need for a log here", + "range": { + "startLine": 305, + "startChar": 34, + "endLine": 305, + "endChar": 54 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "9b7ff2fe_ba37b2aa", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 317, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "This assignment seems unnecessary because capabilities already is sc.capabilities - see line 310", + "range": { + "startLine": 317, + "startChar": 0, + "endLine": 317, + "endChar": 42 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "9c403623_0d5e8e01", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 326, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Same question about log", + "range": { + "startLine": 326, + "startChar": 0, + "endLine": 326, + "endChar": 72 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "d44cc0d1_95867e79", + "filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 362, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Wouldn\u0027t it be better to create a constant to these valid and invalid audit status so that we can use them in the unit tests?", + "range": { + "startLine": 361, + "startChar": 43, + "endLine": 362, + "endChar": 76 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "e7408d28_e6cdc2d1", + "filename": "distributedcloud/dcorch/engine/initial_sync_manager.py", + "patchSetId": 4 + }, + "lineNbr": 13, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Review the range of years with modifications", + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "8ebe6d82_e96c8631", + "filename": "distributedcloud/dcorch/engine/initial_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 14, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Use the new license declaration", + "range": { + "startLine": 1, + "startChar": 0, + "endLine": 14, + "endChar": 32 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "71ac7911_8a44e171", + "filename": "distributedcloud/dcorch/engine/service.py", + "patchSetId": 4 + }, + "lineNbr": 124, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "The todo format is incorrect. It should be TODO(name). I don\u0027t know if the linter will identify this", + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "adce2a9a_9d0ca275", + "filename": "distributedcloud/dcorch/engine/service.py", + "patchSetId": 4 + }, + "lineNbr": 157, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "nit: remember to use f-string", + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "5953de92_3d9c51ed", + "filename": "distributedcloud/dcorch/tests/unit/engine/test_generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 30, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "The base should already have the self.ctx variable", + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "378fb863_5ae9cb62", + "filename": "distributedcloud/dcorch/tests/unit/engine/test_generic_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 114, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Can you move the subcloud creation to setup? It seems to be the same in the tests", + "range": { + "startLine": 109, + "startChar": 0, + "endLine": 114, + "endChar": 67 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "bd47b6a9_1bbaacfb", + "filename": "distributedcloud/dcorch/tests/unit/engine/test_initial_sync_manager.py", + "patchSetId": 4 + }, + "lineNbr": 34, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "The base should already have the self.ctx variable", + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "d6950282_d4f2749c", + "filename": "distributedcloud/dcorch/tests/unit/engine/test_initial_sync_manager.py", + "patchSetId": 4 + }, + "lineNbr": 50, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "These can be moved to a method in the base test class since it\u0027s declared in multiple tests. Then, you just call the method here", + "range": { + "startLine": 40, + "startChar": 0, + "endLine": 50, + "endChar": 31 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "8226bf93_45b6fc15", + "filename": "distributedcloud/dcorch/tests/unit/engine/test_initial_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 63, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Join the conditions in one", + "range": { + "startLine": 62, + "startChar": 0, + "endLine": 63, + "endChar": 55 + }, + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "20185640_e8f858da", + "filename": "distributedcloud/dcorch/tests/unit/engine/test_initial_sync_worker_manager.py", + "patchSetId": 4 + }, + "lineNbr": 78, + "author": { + "id": 36476 + }, + "writtenOn": "2024-05-03T21:42:30Z", + "side": 1, + "message": "Same thing about being in the base class", + "revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file