Update patch set 11
Patch Set 11: (11 comments) Patch-set: 11
This commit is contained in:
Gerrit User 28486
Gerrit Code Review
parent
96d32e90f5
commit
789e958c6a
|
|
@ -0,0 +1,251 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "a1301e4d_a092236f",
|
||||
"filename": "distributedcloud/dcorch/engine/generic_sync_manager.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 123,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "may want to change to debug level because shared resources are infrequently changed",
|
||||
"range": {
|
||||
"startLine": 123,
|
||||
"startChar": 16,
|
||||
"endLine": 123,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "48a2103c_f53d5eb1",
|
||||
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 43,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "can this be renamed to sync_thread_group_manager?",
|
||||
"range": {
|
||||
"startLine": 43,
|
||||
"startChar": 13,
|
||||
"endLine": 43,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7ef6f36d_4f144ed5",
|
||||
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 90,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "Can we add a start sync log here and an end sync log on line 110?",
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e94360e2_0fe4e9cb",
|
||||
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 291,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "In the next commit, please consider moving the OpenStackDriver interactions out of the docorch audit worker to the dcorch audit manager.",
|
||||
"range": {
|
||||
"startLine": 291,
|
||||
"startChar": 0,
|
||||
"endLine": 291,
|
||||
"endChar": 75
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9a00d6a2_98bce238",
|
||||
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 327,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "Consider moving this out of worker and into the manager.",
|
||||
"range": {
|
||||
"startLine": 327,
|
||||
"startChar": 8,
|
||||
"endLine": 327,
|
||||
"endChar": 49
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c279dd2a_3873c2ae",
|
||||
"filename": "distributedcloud/dcorch/engine/initial_sync_worker_manager.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 65,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "Should be info",
|
||||
"range": {
|
||||
"startLine": 65,
|
||||
"startChar": 12,
|
||||
"endLine": 65,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "536659df_17c4d136",
|
||||
"filename": "distributedcloud/dcorch/engine/initial_sync_worker_manager.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 98,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "Can you add a log for end of initial sync here?",
|
||||
"range": {
|
||||
"startLine": 98,
|
||||
"startChar": 17,
|
||||
"endLine": 98,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4901fdea_5d52228b",
|
||||
"filename": "distributedcloud/dcorch/engine/service.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 194,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "Don\u0027t see where this is used, only initialized and stopped",
|
||||
"range": {
|
||||
"startLine": 194,
|
||||
"startChar": 0,
|
||||
"endLine": 194,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0c2d9259_8adede8c",
|
||||
"filename": "distributedcloud/dcorch/engine/sync_services/identity.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 90,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "This log should be a rare one. It can be useful to keep the log at info level.",
|
||||
"range": {
|
||||
"startLine": 90,
|
||||
"startChar": 12,
|
||||
"endLine": 90,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "81b6b58a_59142b31",
|
||||
"filename": "distributedcloud/dcorch/engine/sync_services/sysinv.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 84,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "ditto",
|
||||
"range": {
|
||||
"startLine": 84,
|
||||
"startChar": 12,
|
||||
"endLine": 84,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7abe8c46_c98555a1",
|
||||
"filename": "distributedcloud/ocf/dcorch-engine",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 236,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2024-05-13T23:34:31Z",
|
||||
"side": 1,
|
||||
"message": "This is already done here: https://review.opendev.org/c/starlingx/distcloud/+/917825/2/distributedcloud/ocf/dcorch-engine",
|
||||
"range": {
|
||||
"startLine": 236,
|
||||
"startChar": 4,
|
||||
"endLine": 236,
|
||||
"endChar": 72
|
||||
},
|
||||
"revId": "bdf331c9854c8cc3a588d23dff5bf78dd63eee72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue