From 79648a9695d66e219dc606db61ab71a20c09eff1 Mon Sep 17 00:00:00 2001 From: Mauricio Carmelo Date: Tue, 13 Jun 2023 09:12:00 -0400 Subject: [PATCH] Remove deprecated alarm 250.002 from unit tests Alarm 250.002 is deprecated. As alarm 250.002 is being used in an unit test, this review removes alarm 250.002 from usage. Changed from alarm 250.002 to alarm 250.001. Both alarms have the same characterists: Severity: major Degraded Affecting Severity: none Management Affecticting Severity: warning Alarm ID: 250.002. Alarm message: " Ceph cache tiering configuration is out-of-date" Alarm ID: 250.001. Alarm message: " Configuration is out-of-date." Test Plan: Pass: Executed 'tox -e py39' and unit tests continued to pass Closes-Bug: 2023663 Change-Id: I3d12799e7697172699beba46986764daa105433e Signed-off-by: Mauricio Carmelo --- .../tests/unit/orchestrator/states/kube/test_pre_check.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/distributedcloud/dcmanager/tests/unit/orchestrator/states/kube/test_pre_check.py b/distributedcloud/dcmanager/tests/unit/orchestrator/states/kube/test_pre_check.py index eede28d1a..675ff1ef4 100644 --- a/distributedcloud/dcmanager/tests/unit/orchestrator/states/kube/test_pre_check.py +++ b/distributedcloud/dcmanager/tests/unit/orchestrator/states/kube/test_pre_check.py @@ -61,7 +61,7 @@ KUBERNETES_UPGRADE_HEALTH_RESPONSE_NON_MGMT_AFFECTING_ALARM = \ MEMORY_THRESHOLD_ALARM = FakeAlarm('100.101', 'True') KUBERNETES_UPGRADE_ALARM = FakeAlarm('900.007', 'True') -CEPH_ALARM = FakeAlarm('250.002', 'False') +CONFIG_OUT_OF_DATE_ALARM = FakeAlarm('250.001', 'False') class TestKubeUpgradePreCheckStage(TestKubeUpgradeState): @@ -146,7 +146,7 @@ class TestKubeUpgradePreCheckStage(TestKubeUpgradeState): self.subcloud.id, deploy_status=DEPLOY_STATE_DONE) - self.fm_client.get_alarms.return_value = [CEPH_ALARM, KUBERNETES_UPGRADE_ALARM] + self.fm_client.get_alarms.return_value = [CONFIG_OUT_OF_DATE_ALARM, KUBERNETES_UPGRADE_ALARM] self.sysinv_client.get_kube_upgrade_health.return_value = KUBERNETES_UPGRADE_HEALTH_RESPONSE_MGMT_AFFECTING_ALARM self.sysinv_client.get_kube_upgrades.return_value = [FakeKubeUpgrade()] self.sysinv_client.get_kube_versions.return_value = [