starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(5 comments)

Patch-set: 4
This commit is contained in:
Gerrit User 35230 2024-05-13 13:01:45 +00:00 committed by Gerrit Code Review
parent b1ffa20e4d
commit 8854c3fef5
1 changed files with 120 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

120
56a6cdb1d7b35578f23531f2f8d47065fddec1d9
View File

@ -58,6 +58,30 @@
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1a3ed14c_cf21dd80",
"filename": "distributedcloud/dccommon/tests/unit/test_endpoint_cache.py",
"patchSetId": 4
},
"lineNbr": 151,
"author": {
"id": 35230
},
"writtenOn": "2024-05-13T13:01:45Z",
"side": 1,
"message": "I only moved the get_admin_session mock because it was used in all the existing tests. The validate and _generate_master_service_endpoint_map are not used by the test_get_endpoint test so I didn\u0027t move it to the setUp method.",
"parentUuid": "13f9c9ea_12ab23bf",
"range": {
"startLine": 149,
"startChar": 0,
"endLine": 151,
"endChar": 63
},
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -81,6 +105,30 @@
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b5804b47_6d7e0ee3",
"filename": "distributedcloud/dccommon/tests/unit/test_endpoint_cache.py",
"patchSetId": 4
},
"lineNbr": 183,
"author": {
"id": 35230
},
"writtenOn": "2024-05-13T13:01:45Z",
"side": 1,
"message": "Done",
"parentUuid": "7e39f8ff_046a1417",
"range": {
"startLine": 183,
"startChar": 8,
"endLine": 183,
"endChar": 45
},
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -104,6 +152,30 @@
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6617822f_c964ba44",
"filename": "distributedcloud/dccommon/tests/unit/test_endpoint_cache.py",
"patchSetId": 4
},
"lineNbr": 191,
"author": {
"id": 35230
},
"writtenOn": "2024-05-13T13:01:45Z",
"side": 1,
"message": "Done",
"parentUuid": "2c1bdcbd_7a47511b",
"range": {
"startLine": 183,
"startChar": 0,
"endLine": 191,
"endChar": 82
},
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -127,6 +199,30 @@
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ec8aba7b_d68d5510",
"filename": "distributedcloud/dccommon/tests/unit/test_endpoint_cache.py",
"patchSetId": 4
},
"lineNbr": 194,
"author": {
"id": 35230
},
"writtenOn": "2024-05-13T13:01:45Z",
"side": 1,
"message": "Done",
"parentUuid": "2c59282b_23f539ec",
"range": {
"startLine": 194,
"startChar": 0,
"endLine": 194,
"endChar": 25
},
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -149,6 +245,30 @@
},
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d7f11e37_fdf9aa5e",
"filename": "distributedcloud/dccommon/tests/unit/test_endpoint_cache.py",
"patchSetId": 4
},
"lineNbr": 217,
"author": {
"id": 35230
},
"writtenOn": "2024-05-13T13:01:45Z",
"side": 1,
"message": "Done",
"parentUuid": "15cf7486_526008d3",
"range": {
"startLine": 198,
"startChar": 0,
"endLine": 217,
"endChar": 9
},
"revId": "56a6cdb1d7b35578f23531f2f8d47065fddec1d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}