starlingx/distcloud
Code Issues Proposed changes

Update patch set 11

Browse Source 
Patch Set 11:

(3 comments)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 35809 \u003c35809@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35809\u003e replied on the change"}
This commit is contained in:
Gerrit User 35809 2024-04-25 13:21:22 +00:00 committed by Gerrit Code Review
parent 09f938d7c6
commit 97a3454347
2 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
18ea7209d7003c39ad446700df70c721bdd21915
View File

@ -228,6 +228,24 @@
"revId": "18ea7209d7003c39ad446700df70c721bdd21915", "revId": "18ea7209d7003c39ad446700df70c721bdd21915",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}, },
{
"unresolved": false,
"key": {
"uuid": "71c83a61_f9fec9e9",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 7
},
"lineNbr": 3928,
"author": {
"id": 35809
},
"writtenOn": "2024-04-25T13:21:22Z",
"side": 1,
"message": "In one of the unit test _create_intermediate_ca_cert was executing so using it only in required unit test",
"parentUuid": "268b4c8d_8c361cca",
"revId": "18ea7209d7003c39ad446700df70c721bdd21915",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{ {
"unresolved": true, "unresolved": true,
"key": { "key": {

42
5e0e5d5051599d7ff0132312506685924316be86
View File

@ -35,6 +35,24 @@
"revId": "5e0e5d5051599d7ff0132312506685924316be86", "revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}, },
{
"unresolved": false,
"key": {
"uuid": "33226670_4f79b5a3",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 35809
},
"writtenOn": "2024-04-25T13:21:22Z",
"side": 1,
"message": "added under TestSubcloudManager",
"parentUuid": "c7da0ed8_463b0a07",
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{ {
"unresolved": true, "unresolved": true,
"key": { "key": {
@ -105,6 +123,30 @@
"revId": "5e0e5d5051599d7ff0132312506685924316be86", "revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}, },
{
"unresolved": false,
"key": {
"uuid": "48044a52_24891022",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4402,
"author": {
"id": 35809
},
"writtenOn": "2024-04-25T13:21:22Z",
"side": 1,
"message": "removing in TestSubcloudInstall effects in below 2UT\u0027s due to mock ordering\ntest_subcloud_install\ntest_subcloud_install_with_aborted_install",
"parentUuid": "9cff7398_fe1c3476",
"range": {
"startLine": 4401,
"startChar": 8,
"endLine": 4402,
"endChar": 50
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{ {
"unresolved": true, "unresolved": true,
"key": { "key": {