starlingx/distcloud
Code Issues Proposed changes

Update patch set 19

Browse Source 
Patch Set 19:

(2 comments)

Patch-set: 19
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35809\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35809\u003e replied on the change"}
This commit is contained in:
Gerrit User 35809 2024-05-08 16:25:49 +00:00 committed by Gerrit Code Review
parent e9dc74812c
commit a26ce10a5e
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
362bfbc4f4b1b8493fe1c7f27134b7514d408dc4
View File

@ -194,6 +194,24 @@
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4", "revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}, },
{
"unresolved": false,
"key": {
"uuid": "69955542_defd6c8f",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 593,
"author": {
"id": 35809
},
"writtenOn": "2024-05-08T16:25:49Z",
"side": 1,
"message": "sorry, I missed this UT.\nUT was failing by removing json.dumps mocking and not possible to mock kubernetes V1Secret object",
"parentUuid": "b133eade_5ce00618",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{ {
"unresolved": true, "unresolved": true,
"key": { "key": {
@ -312,6 +330,30 @@
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4", "revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}, },
{
"unresolved": false,
"key": {
"uuid": "02de3f62_f8527823",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 662,
"author": {
"id": 35809
},
"writtenOn": "2024-05-08T16:25:49Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "c28f8fb1_d0be4a00",
"range": {
"startLine": 654,
"startChar": 0,
"endLine": 662,
"endChar": 9
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{ {
"unresolved": true, "unresolved": true,
"key": { "key": {