From e5904ccef98840943f3b42c0d4fbc67f033ced07 Mon Sep 17 00:00:00 2001
From: Gerrit User 35809 <35809@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Thu, 18 Apr 2024 14:24:14 +0000
Subject: [PATCH] Update patch set 8

Patch Set 8:

(10 comments)

Patch-set: 8
Attention: {"person_ident":"Gerrit User 35809 \u003c35809@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35809\u003e replied on the change"}
---
 b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17 | 228 +++++++++++++++++++++++
 1 file changed, 228 insertions(+)

diff --git a/b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17 b/b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17
index 5cf1d5652..44e6eddf6 100644
--- a/b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17
+++ b/b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17
@@ -211,6 +211,30 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "6f44a9d8_e0f5d8f5",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 2630,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "changed the backup_status in assertion to consts.BACKUP_STATE_FAILED. and added mock to success _create_backup_overrides_file",
+      "parentUuid": "4a5994ca_297d4d2d",
+      "range": {
+        "startLine": 2630,
+        "startChar": 32,
+        "endLine": 2630,
+        "endChar": 56
+      },
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -281,6 +305,30 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "b0f2e9f5_15357302",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 2636,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "Testing subcloud backup when subcloud backup state is in-progress.",
+      "parentUuid": "acd345ea_6aef3595",
+      "range": {
+        "startLine": 2636,
+        "startChar": 0,
+        "endLine": 2636,
+        "endChar": 2
+      },
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -386,6 +434,30 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "6242e977_b338f32a",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 3288,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "Acknowledged",
+      "parentUuid": "016c1c90_be3efe73",
+      "range": {
+        "startLine": 3287,
+        "startChar": 8,
+        "endLine": 3288,
+        "endChar": 40
+      },
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -456,6 +528,30 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "423de349_0435b162",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 3314,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "added mock_log.info to make sure the restore succeeded.",
+      "parentUuid": "168e0683_7b7ef680",
+      "range": {
+        "startLine": 3313,
+        "startChar": 8,
+        "endLine": 3314,
+        "endChar": 56
+      },
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -526,6 +622,30 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "17f257d3_c83b87e4",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 3351,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "added mock_log.info to make sure the restore succeeded.",
+      "parentUuid": "38f30f9c_9c954ec2",
+      "range": {
+        "startLine": 3350,
+        "startChar": 0,
+        "endLine": 3351,
+        "endChar": 56
+      },
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -643,6 +763,30 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "1d174b49_bb77d33a",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 3377,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "Subcloud must be unmanaged for backup restore operation.",
+      "parentUuid": "399bc0c4_60f5ad1d",
+      "range": {
+        "startLine": 3377,
+        "startChar": 23,
+        "endLine": 3377,
+        "endChar": 67
+      },
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -818,6 +962,30 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "ca9b39ed_f71917d3",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 3776,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "Acknowledged",
+      "parentUuid": "2e130f78_2b8f1b90",
+      "range": {
+        "startLine": 3776,
+        "startChar": 4,
+        "endLine": 3776,
+        "endChar": 52
+      },
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -835,6 +1003,24 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "5641bc88_2c5567f4",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 3780,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "removed UT since it was not increasing coverage.",
+      "parentUuid": "07c1c754_40c08b50",
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -1117,6 +1303,30 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "e5bdbfe6_36daeffe",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 4218,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "Acknowledged",
+      "parentUuid": "caecfb1b_a1cea1ea",
+      "range": {
+        "startLine": 4212,
+        "startChar": 0,
+        "endLine": 4218,
+        "endChar": 47
+      },
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -1216,6 +1426,24 @@
       "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "9c5ebfbb_28136e74",
+        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 4294,
+      "author": {
+        "id": 35809
+      },
+      "writtenOn": "2024-04-18T14:24:14Z",
+      "side": 1,
+      "message": "Acknowledged",
+      "parentUuid": "471826c2_97c2b3c8",
+      "revId": "b8fe6d4cec2ce1d632fab7cd2cab19bf190eef17",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {