starlingx
/
distcloud
Code Issues Proposed changes
distcloud/8284580c431615b7c19c6ebf956...

309 lines
9.0 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e66b5bf2_7f2ceaf1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 8
},
"lineNbr": 0,
"author": {
"id": 36476
},
"writtenOn": "2024-03-20T13:18:43Z",
"side": 1,
"message": "Please, review the code and remove the duplications to simplify the testing",
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9755eefa_450ff4ec",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 8
},
"lineNbr": 0,
"author": {
"id": 35809
},
"writtenOn": "2024-05-03T14:13:16Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "e66b5bf2_7f2ceaf1",
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ae5e255b_c0ec41ec",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 68,
"author": {
"id": 36476
},
"writtenOn": "2024-03-20T13:18:43Z",
"side": 1,
"message": "Create a single method to create the fake sites instead of using multiple variables and duplicating the code",
"range": {
"startLine": 64,
"startChar": 0,
"endLine": 68,
"endChar": 64
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "370ecbfb_56ead8e9",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 68,
"author": {
"id": 35809
},
"writtenOn": "2024-04-29T05:43:07Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "ae5e255b_c0ec41ec",
"range": {
"startLine": 64,
"startChar": 0,
"endLine": 68,
"endChar": 64
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9b310c05_26ece59c",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 138,
"author": {
"id": 36476
},
"writtenOn": "2024-03-20T13:18:43Z",
"side": 1,
"message": "All of the classes above should be unnecessary. As long as the mocks are created, you can create the same behaviour without adding the complexity of using these",
"range": {
"startLine": 84,
"startChar": 1,
"endLine": 138,
"endChar": 8
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "abcad0dc_eb65bf4e",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 138,
"author": {
"id": 35809
},
"writtenOn": "2024-04-29T05:43:07Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "9b310c05_26ece59c",
"range": {
"startLine": 84,
"startChar": 1,
"endLine": 138,
"endChar": 8
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "73e468c5_5e4df037",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 145,
"author": {
"id": 36476
},
"writtenOn": "2024-03-20T13:18:43Z",
"side": 1,
"message": "In super, you don\u0027t need to specify the class and self. Opt for super().setUp().\nThis comment also applies to the other classes",
"range": {
"startLine": 145,
"startChar": 8,
"endLine": 145,
"endChar": 50
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fe46093c_8b3752bf",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 145,
"author": {
"id": 35809
},
"writtenOn": "2024-04-29T05:43:07Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "73e468c5_5e4df037",
"range": {
"startLine": 145,
"startChar": 8,
"endLine": 145,
"endChar": 50
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c479cdba_97aab1ba",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 287,
"author": {
"id": 36476
},
"writtenOn": "2024-03-20T13:18:43Z",
"side": 1,
"message": "Is it really necessary to mock utils? Can\u0027t the behavior be replicated without it? This will reduce its coverage",
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b59bf7e1_0206da46",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 287,
"author": {
"id": 35809
},
"writtenOn": "2024-04-29T05:43:07Z",
"side": 1,
"message": "yes, we are mocking utils get_local_system \n\nadded _mock_get_local_system in base.py since we are using it in test_subcloud_manager.py also",
"parentUuid": "c479cdba_97aab1ba",
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ba611f90_b2bf2773",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 289,
"author": {
"id": 36476
},
"writtenOn": "2024-03-20T13:18:43Z",
"side": 1,
"message": "Use a single mock for these classes using the same structure from base.",
"range": {
"startLine": 288,
"startChar": 0,
"endLine": 289,
"endChar": 62
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5556f2b2_4c20934c",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 289,
"author": {
"id": 35809
},
"writtenOn": "2024-04-29T05:43:07Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "ba611f90_b2bf2773",
"range": {
"startLine": 288,
"startChar": 0,
"endLine": 289,
"endChar": 62
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a54856fb_ef38d3e8",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 339,
"author": {
"id": 36476
},
"writtenOn": "2024-03-20T13:18:43Z",
"side": 1,
"message": "All of these mocks specifications are duplicated in most test cases, use the base.py structure in order to simplify this.",
"range": {
"startLine": 329,
"startChar": 8,
"endLine": 339,
"endChar": 56
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7d1b8972_6660ebcb",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 8
},
"lineNbr": 339,
"author": {
"id": 35809
},
"writtenOn": "2024-04-29T05:43:07Z",
"side": 1,
"message": "added common mocks under base.py",
"parentUuid": "a54856fb_ef38d3e8",
"range": {
"startLine": 329,
"startChar": 8,
"endLine": 339,
"endChar": 56
},
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink