105a5d4c0d
Patch Set 8: (7 comments) Patch-set: 8 Attention: {"person_ident":"Gerrit User 35441 \u003c35441@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35441\u003e replied on the change"}
266 lines
7.8 KiB
Plaintext
266 lines
7.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "78692af5_2db58643",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-23T13:35:52Z",
|
|
"side": 1,
|
|
"message": "Please, resolve the comments after being addressed.",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e2c7b3f1_7b37b4d8",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 524,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-23T13:45:29Z",
|
|
"side": 1,
|
|
"message": "msg \u003d f\u0027Subcloud deploy status must be either: {valid_states_str}\u0027\npecan.abort(400, _(msg))",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5d2eaa91_92ebf90d",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 524,
|
|
"author": {
|
|
"id": 35441
|
|
},
|
|
"writtenOn": "2024-04-24T18:37:45Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "e2c7b3f1_7b37b4d8",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a5e84b10_b473b67a",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 541,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-23T13:45:29Z",
|
|
"side": 1,
|
|
"message": "nit: don\u0027t need to use `f` in the first line of the msg.",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "164dd578_70bd920f",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 541,
|
|
"author": {
|
|
"id": 35441
|
|
},
|
|
"writtenOn": "2024-04-24T18:37:45Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "a5e84b10_b473b67a",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "81afb33b_2d5c4d2d",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 543,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-23T13:45:29Z",
|
|
"side": 1,
|
|
"message": "_(msg)",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "778b3696_f800dec3",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 543,
|
|
"author": {
|
|
"id": 35441
|
|
},
|
|
"writtenOn": "2024-04-24T18:37:45Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "81afb33b_2d5c4d2d",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "aab5cd5a_8dd1659a",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 550,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-23T13:45:29Z",
|
|
"side": 1,
|
|
"message": "If additional commits are required to complete this development, please create stub tests for now and implement them later.",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2997da41_f9cadb80",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 550,
|
|
"author": {
|
|
"id": 35441
|
|
},
|
|
"writtenOn": "2024-04-24T18:37:45Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "aab5cd5a_8dd1659a",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d90c9f73_5c24b15c",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 602,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-23T13:45:29Z",
|
|
"side": 1,
|
|
"message": "remove TODO",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "207f1511_5f1f1817",
|
|
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 602,
|
|
"author": {
|
|
"id": 35441
|
|
},
|
|
"writtenOn": "2024-04-24T18:37:45Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d90c9f73_5c24b15c",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2319367d_adea87d3",
|
|
"filename": "distributedcloud/dcmanager/common/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 167,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-23T13:45:29Z",
|
|
"side": 1,
|
|
"message": "this line is not necessary.",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "333cdb1f_058a9b3a",
|
|
"filename": "distributedcloud/dcmanager/common/phased_subcloud_deploy.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 167,
|
|
"author": {
|
|
"id": 35441
|
|
},
|
|
"writtenOn": "2024-04-24T18:37:45Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "2319367d_adea87d3",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "63ab93c1_05b9ae06",
|
|
"filename": "distributedcloud/dcmanager/manager/subcloud_manager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1577,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-23T13:45:29Z",
|
|
"side": 1,
|
|
"message": "We can use: raise NotImplementedError",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "87185d8f_817716fa",
|
|
"filename": "distributedcloud/dcmanager/manager/subcloud_manager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1577,
|
|
"author": {
|
|
"id": 35441
|
|
},
|
|
"writtenOn": "2024-04-24T18:37:45Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "63ab93c1_05b9ae06",
|
|
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |