starlingx/distcloud
Code Issues Proposed changes
46f55cb0d0
distcloud/5e0e5d5051599d7ff0132312506685924316be86
Gerrit User 36476 b9cc392904 Update patch set 7 
Patch Set 7:

(9 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35809 \u003c35809@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
2024-04-23 13:08:43 +00:00

567 lines
17 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "85246242_410c644f",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "There is some of code duplication in the TestSubcloudInstall, TestNetworkReconfig and TestRenameSubcloud tests. Please consider creating some utility functions or/and using the setUp function to do whatever is common across all the tests to improve this if possible.",
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c7da0ed8_463b0a07",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 36476
},
"writtenOn": "2024-04-23T13:08:43Z",
"side": 1,
"message": "+1",
"parentUuid": "85246242_410c644f",
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8783a4a3_308ca2f6",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 2736,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "nit: I\u0027d revert these formatting changes considering the linter is passing.",
"range": {
"startLine": 2735,
"startChar": 0,
"endLine": 2736,
"endChar": 76
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0784ac98_a27fa28e",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 2736,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "8783a4a3_308ca2f6",
"range": {
"startLine": 2735,
"startChar": 0,
"endLine": 2736,
"endChar": 76
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9cff7398_fe1c3476",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4402,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "This is already mocked by the TestSubcloudManager parent class.\n\nYou\u0027ll need to reference the self.mock_install_openstack_driver and self.mock_install_sysinv_client during the tests bellow.",
"range": {
"startLine": 4401,
"startChar": 8,
"endLine": 4402,
"endChar": 50
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "032789ef_96d6acc8",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4409,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "Already mocked by the TestSubcloudManager parent class. Same comment for the other tests",
"range": {
"startLine": 4409,
"startChar": 4,
"endLine": 4409,
"endChar": 27
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cb9696b8_3f2056ba",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4409,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "032789ef_96d6acc8",
"range": {
"startLine": 4409,
"startChar": 4,
"endLine": 4409,
"endChar": 27
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "06bb890f_143c1bac",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4413,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "If these mocks are duplicated in all the install tests, I\u0027d mock them inside the TestSubcloudInstall setUp function.",
"range": {
"startLine": 4404,
"startChar": 0,
"endLine": 4413,
"endChar": 55
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9a69d876_471c3f40",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4413,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:27:33Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "06bb890f_143c1bac",
"range": {
"startLine": 4404,
"startChar": 0,
"endLine": 4413,
"endChar": 55
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bffc7dfb_f1b305e9",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4436,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "This is already defined inside the TestSubcloudManager class. This also happens with the other tests bellow.",
"range": {
"startLine": 4436,
"startChar": 8,
"endLine": 4436,
"endChar": 47
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bfb2f084_f5d5840d",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4436,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "bffc7dfb_f1b305e9",
"range": {
"startLine": 4436,
"startChar": 8,
"endLine": 4436,
"endChar": 47
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f5300687_b474190a",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4441,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "You can pass FAKE_LOG_FILE directly, same comment for the other tests",
"range": {
"startLine": 4441,
"startChar": 12,
"endLine": 4441,
"endChar": 25
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "85d8b20c_953345ac",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4441,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "f5300687_b474190a",
"range": {
"startLine": 4441,
"startChar": 12,
"endLine": 4441,
"endChar": 25
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "af033c47_cf51b7fa",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4593,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "This test doesn\u0027t fit inside the TestSubcloudInstall class, might be better to move to the update class. Same thing for the test bellow",
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2abc3d36_e658891d",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4593,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "af033c47_cf51b7fa",
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "36ad0443_30368200",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4601,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "nit: Just pass the consts directly: dccommon_consts.ENDPOINT_TYPES_LIST_OS",
"range": {
"startLine": 4601,
"startChar": 51,
"endLine": 4601,
"endChar": 69
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "57537424_8fdba035",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4601,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "36ad0443_30368200",
"range": {
"startLine": 4601,
"startChar": 51,
"endLine": 4601,
"endChar": 69
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8b8c58a8_f8725c6e",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4619,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "Should probably get it from base.SUBCLOUD_1[\u0027region_name\u0027] so if it\u0027s ever modified, the test wont need to be updated.",
"range": {
"startLine": 4619,
"startChar": 37,
"endLine": 4619,
"endChar": 69
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ec706764_e28a176a",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4619,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "8b8c58a8_f8725c6e",
"range": {
"startLine": 4619,
"startChar": 37,
"endLine": 4619,
"endChar": 69
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8bd43828_97b798eb",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4629,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "These are using on all the Network Reconfig tests, so I recommend moving them to the setUp function above.",
"range": {
"startLine": 4628,
"startChar": 4,
"endLine": 4629,
"endChar": 44
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "174765ab_36da45f5",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4629,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "8bd43828_97b798eb",
"range": {
"startLine": 4628,
"startChar": 4,
"endLine": 4629,
"endChar": 44
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e2dd2970_3953f9b1",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4869,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "Doesn\u0027t fit inside the TestNetworkReconfig class. If we don\u0027t have a class just for the geo-redundancy related tests, maybe the base TestSubcloudManager could be used for these tests that doesn\u0027t fit anywhere else.",
"range": {
"startLine": 4837,
"startChar": 0,
"endLine": 4869,
"endChar": 45
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f27173e7_3745f798",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4869,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "added under BaseTestSubcloudManager",
"parentUuid": "e2dd2970_3953f9b1",
"range": {
"startLine": 4837,
"startChar": 0,
"endLine": 4869,
"endChar": 45
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "73939fca_fb7d9105",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4872,
"author": {
"id": 35230
},
"writtenOn": "2024-04-08T20:02:15Z",
"side": 1,
"message": "nit: TestSubcloudRename",
"range": {
"startLine": 4872,
"startChar": 6,
"endLine": 4872,
"endChar": 24
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "455719fd_4efecd4a",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 4872,
"author": {
"id": 35809
},
"writtenOn": "2024-04-23T05:26:39Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "73939fca_fb7d9105",
"range": {
"startLine": 4872,
"startChar": 6,
"endLine": 4872,
"endChar": 24
},
"revId": "5e0e5d5051599d7ff0132312506685924316be86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink