starlingx/distcloud
Code Issues Proposed changes
95e1778813
distcloud/5803eb1b011549e39f96ac46dd5290ad670e2459
Gerrit User 36476 95e1778813 Update patch set 5 
Patch Set 5:

(1 comment)

Patch-set: 5
2024-04-25 19:09:45 +00:00

912 lines
27 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "c77cefb2_d9a2eb70",
"filename": "distributedcloud/dccommon/tests/unit/test_utils.py",
"patchSetId": 3
},
"lineNbr": 2,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "2024",
"range": {
"startLine": 2,
"startChar": 21,
"endLine": 2,
"endChar": 25
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "27f544ca_6e0b99ef",
"filename": "distributedcloud/dccommon/tests/unit/test_utils.py",
"patchSetId": 3
},
"lineNbr": 2,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "c77cefb2_d9a2eb70",
"range": {
"startLine": 2,
"startChar": 21,
"endLine": 2,
"endChar": 25
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9ce69f1f_0586c984",
"filename": "distributedcloud/dcmanager/tests/base.py",
"patchSetId": 3
},
"lineNbr": 205,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "setattr(self, name, mock_patch_object.start())",
"range": {
"startLine": 205,
"startChar": 8,
"endLine": 205,
"endChar": 55
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d02bfe68_8fe91ce7",
"filename": "distributedcloud/dcmanager/tests/base.py",
"patchSetId": 3
},
"lineNbr": 205,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "9ce69f1f_0586c984",
"range": {
"startLine": 205,
"startChar": 8,
"endLine": 205,
"endChar": 55
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7bdd7392_c382ec40",
"filename": "distributedcloud/dcmanager/tests/base.py",
"patchSetId": 3
},
"lineNbr": 217,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "setattr(self, name, mock_patch_object.start())",
"range": {
"startLine": 217,
"startChar": 8,
"endLine": 217,
"endChar": 55
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "59dde663_75cc0f6e",
"filename": "distributedcloud/dcmanager/tests/base.py",
"patchSetId": 3
},
"lineNbr": 217,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "7bdd7392_c382ec40",
"range": {
"startLine": 217,
"startChar": 8,
"endLine": 217,
"endChar": 55
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e3da523f_e83a587e",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_phased_subcloud_deploy.py",
"patchSetId": 3
},
"lineNbr": 89,
"author": {
"id": 36476
},
"writtenOn": "2024-04-17T21:12:08Z",
"side": 1,
"message": "These changes were necessary because the new test cases for subclouds does not apply for phased_subcloud_deployment and, therefore, resulted in errors. By adding the required tests here, such dependency was removed.",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "45b09ab6_bad6e965",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 333,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "This test seems redundant, I\u0027d remove it and rename the previous one from test_get_succeeds to test_get_succeeds_with_subcloud_id.",
"range": {
"startLine": 326,
"startChar": 0,
"endLine": 333,
"endChar": 63
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ea7188b3_c584cedc",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 333,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "It actually isn\u0027t redundant because the get request has two different behaviors: if there isn\u0027t a subcloud_ref, a list of subclouds is returned. Otherwise, if an id or name is sent, a subcloud\u0027s details is returned.\nI\u0027ve added a comment to specify that.",
"parentUuid": "45b09ab6_bad6e965",
"range": {
"startLine": 326,
"startChar": 0,
"endLine": 333,
"endChar": 63
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b0e9655c_f8da8627",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 752,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "Docstring not matching the test name",
"range": {
"startLine": 752,
"startChar": 8,
"endLine": 752,
"endChar": 73
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1759f6f3_fd6d5710",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 752,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "b0e9655c_f8da8627",
"range": {
"startLine": 752,
"startChar": 8,
"endLine": 752,
"endChar": 73
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ee871fb5_9d85cfc2",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 804,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "Redefining the built-in \u0027property\u0027. I suggest using \u0027field\u0027 or \u0027_property\u0027 instead.\n\nSame for other uses of the \u0027property\u0027 on the next function.",
"range": {
"startLine": 804,
"startChar": 14,
"endLine": 804,
"endChar": 22
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "33d20663_48d9fe13",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 804,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "ee871fb5_9d85cfc2",
"range": {
"startLine": 804,
"startChar": 14,
"endLine": 804,
"endChar": 22
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3f61fdd8_d8c74af6",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 913,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "Deleting the new fields is not necessary as unittests runs each test with fresh instances of the test class.",
"range": {
"startLine": 913,
"startChar": 8,
"endLine": 913,
"endChar": 49
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c5bad857_6796f632",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 913,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "In those cases, they are necessary. If I remove those, from this test case and the one you commented below, they start to fail.",
"parentUuid": "3f61fdd8_d8c74af6",
"range": {
"startLine": 913,
"startChar": 8,
"endLine": 913,
"endChar": 49
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e816415e_037a0e45",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 963,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "Deleting the new fields is not necessary as unittests runs each test with fresh instances of the test class.",
"range": {
"startLine": 960,
"startChar": 0,
"endLine": 963,
"endChar": 53
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ac064db2_3320fc39",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 963,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Same comment as stated above.",
"parentUuid": "e816415e_037a0e45",
"range": {
"startLine": 960,
"startChar": 0,
"endLine": 963,
"endChar": 53
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "11de81e1_4256ae31",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1093,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "Is this TODO still relevant?",
"range": {
"startLine": 1093,
"startChar": 0,
"endLine": 1093,
"endChar": 54
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cec68360_7eff9a78",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1093,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Yes, if a None is sent in the network address a TypeError occurs. I believe we should create a bug for that.",
"parentUuid": "11de81e1_4256ae31",
"range": {
"startLine": 1093,
"startChar": 0,
"endLine": 1093,
"endChar": 54
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9a4bef86_2986613e",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1157,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "The rpc method should return a dict instead of a subcloud object. You can use the db_api.subcloud_db_model_to_dict() to convert it.\n\nThis commit also applies to lines: 1517, 1610 and 1779",
"range": {
"startLine": 1157,
"startChar": 8,
"endLine": 1157,
"endChar": 75
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6a76361e_0a5fd97d",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1157,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "9a4bef86_2986613e",
"range": {
"startLine": 1157,
"startChar": 8,
"endLine": 1157,
"endChar": 75
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "01cd39c7_86810420",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1159,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T12:02:14Z",
"side": 1,
"message": "Redefining the built-in \u0027property\u0027. I suggest using \u0027field\u0027 or \u0027_property\u0027 instead.",
"range": {
"startLine": 1159,
"startChar": 49,
"endLine": 1159,
"endChar": 57
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d053d34a_ea5b60e9",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1159,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "01cd39c7_86810420",
"range": {
"startLine": 1159,
"startChar": 49,
"endLine": 1159,
"endChar": 57
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f6e9ee0d_0ebdd5f1",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1371,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T18:10:03Z",
"side": 1,
"message": "nit: change to a space",
"range": {
"startLine": 1371,
"startChar": 70,
"endLine": 1371,
"endChar": 71
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "847eb3ed_e271a02e",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1371,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "f6e9ee0d_0ebdd5f1",
"range": {
"startLine": 1371,
"startChar": 70,
"endLine": 1371,
"endChar": 71
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "179ceb3f_50021eaf",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1427,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T18:10:03Z",
"side": 1,
"message": "Suggestion: add an extra assertion to verify that the get_strategy was called once, otherwise this test could pass whenever the _check_existing_vim_strategy returns false, even without reaching the \"check the system config update strategy\" block.",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b635b35c_8b6276a1",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1427,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "179ceb3f_50021eaf",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5a6a34f8_26698b38",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1764,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T18:10:03Z",
"side": 1,
"message": "nit:\n\n rehome_data\u003d\u0027{\"saved_payload\": {\"system_mode\": \"simplex\",\u0027\n \u0027\"bootstrap-address\": \"192.168.100.100\"}}\u0027",
"range": {
"startLine": 1763,
"startChar": 12,
"endLine": 1764,
"endChar": 70
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e163e13b_981b3483",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1764,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "5a6a34f8_26698b38",
"range": {
"startLine": 1763,
"startChar": 12,
"endLine": 1764,
"endChar": 70
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e53f252f_6a97aa67",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1805,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T18:10:03Z",
"side": 1,
"message": "We need to assert that the update_subcloud was called passing the peer_group_id\u003dself.peer_group.id. Maybe something like this:\n\n _, kwargs \u003d self.mock_rpc_client().update_subcloud.call_args\n self.assertEqual(self.peer_group.id, kwargs.get(\u0027peer_group_id\u0027))",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e9eb547a_748fe39c",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1805,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "e53f252f_6a97aa67",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1d515880_d3ed4812",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1848,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T18:10:03Z",
"side": 1,
"message": "Need to assert that the update_subcloud was called passing the peer_group_id\u003d\"none\"",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bed6c41d_dda128bd",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1848,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "1d515880_d3ed4812",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d459f949_a272ccb5",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 2243,
"author": {
"id": 35230
},
"writtenOn": "2024-04-24T18:10:03Z",
"side": 1,
"message": "nit: to avoid redefining the built-in property, use \u0027param\u0027 or \u0027field\u0027 instead.",
"range": {
"startLine": 2243,
"startChar": 19,
"endLine": 2243,
"endChar": 27
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "695d9c2e_6424d618",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 2243,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "d459f949_a272ccb5",
"range": {
"startLine": 2243,
"startChar": 19,
"endLine": 2243,
"endChar": 27
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1ddd2376_d7d49e8d",
"filename": "distributedcloud/dcmanager/tests/unit/common/test_phased_subcloud_deploy.py",
"patchSetId": 3
},
"lineNbr": 69,
"author": {
"id": 36476
},
"writtenOn": "2024-04-17T21:12:08Z",
"side": 1,
"message": "All of the methods added here were moved from test_subclouds",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2d48cfc9_5d45e3dd",
"filename": "distributedcloud/dcmanager/tests/unit/common/test_phased_subcloud_deploy.py",
"patchSetId": 3
},
"lineNbr": 258,
"author": {
"id": 35230
},
"writtenOn": "2024-04-25T12:58:06Z",
"side": 1,
"message": "These tests are duplicated in this file",
"range": {
"startLine": 193,
"startChar": 0,
"endLine": 258,
"endChar": 5
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c70bda27_e3e8312b",
"filename": "distributedcloud/dcmanager/tests/unit/common/test_phased_subcloud_deploy.py",
"patchSetId": 3
},
"lineNbr": 258,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:46Z",
"side": 1,
"message": "Done",
"parentUuid": "2d48cfc9_5d45e3dd",
"range": {
"startLine": 193,
"startChar": 0,
"endLine": 258,
"endChar": 5
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ebd7e41b_753a96ef",
"filename": "distributedcloud/dcmanager/tests/unit/utils/test_utils.py",
"patchSetId": 3
},
"lineNbr": 2,
"author": {
"id": 35230
},
"writtenOn": "2024-04-25T12:58:06Z",
"side": 1,
"message": ", 2024",
"range": {
"startLine": 2,
"startChar": 32,
"endLine": 2,
"endChar": 33
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ae49029d_81108b3f",
"filename": "distributedcloud/dcmanager/tests/unit/utils/test_utils.py",
"patchSetId": 3
},
"lineNbr": 2,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T19:09:45Z",
"side": 1,
"message": "Done",
"parentUuid": "ebd7e41b_753a96ef",
"range": {
"startLine": 2,
"startChar": 32,
"endLine": 2,
"endChar": 33
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "399d6b9e_176b597f",
"filename": "distributedcloud/dcmanager/tests/unit/utils/test_utils.py",
"patchSetId": 3
},
"lineNbr": 47,
"author": {
"id": 36476
},
"writtenOn": "2024-04-17T21:12:08Z",
"side": 1,
"message": "All of the methods added here were moved from test_subclouds",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink