3fcf9ef4b2
Patch Set 14: (21 comments) Patch-set: 14 Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
27 lines
818 B
Plaintext
27 lines
818 B
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4bd371fe_ce3d801b",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 2382,
|
|
"author": {
|
|
"id": 35230
|
|
},
|
|
"writtenOn": "2024-05-06T20:02:38Z",
|
|
"side": 0,
|
|
"message": "We should keep the copy(), otherwise the original dictionaries inside subcloud_manager are going to be modified in line 2387, which modifies the \u0027undefined state\u0027 test meaning.",
|
|
"range": {
|
|
"startLine": 2380,
|
|
"startChar": 0,
|
|
"endLine": 2382,
|
|
"endChar": 82
|
|
},
|
|
"revId": "0a3c96c766297b7312d6a6fdff9acd8a0b319e87",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |