starlingx/distcloud
Code Issues Proposed changes
9c17c62cda
distcloud/362bfbc4f4b1b8493fe1c7f27134b7514d408dc4
Gerrit User 35230 3fcf9ef4b2 Update patch set 14 
Patch Set 14:

(21 comments)

Patch-set: 14
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
2024-05-06 20:02:38 +00:00

536 lines
16 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "3e9a6ced_91fe3cc7",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 375,
"author": {
"id": 36476
},
"writtenOn": "2024-04-29T20:24:30Z",
"side": 1,
"message": "This should be called test_system_peer_manager",
"range": {
"startLine": 375,
"startChar": 13,
"endLine": 375,
"endChar": 29
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e8147a94_09367eb4",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 375,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "3e9a6ced_91fe3cc7",
"range": {
"startLine": 375,
"startChar": 13,
"endLine": 375,
"endChar": 29
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cf55d4c7_7c620c3c",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 489,
"author": {
"id": 36476
},
"writtenOn": "2024-04-29T20:24:30Z",
"side": 1,
"message": "\"\"\"Mock subprocess\u0027 run\"\"\"",
"range": {
"startLine": 489,
"startChar": 0,
"endLine": 489,
"endChar": 35
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "656c9776_99c68443",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 489,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "cf55d4c7_7c620c3c",
"range": {
"startLine": 489,
"startChar": 0,
"endLine": 489,
"endChar": 35
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c4cb6293_f3e60a33",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 582,
"author": {
"id": 36476
},
"writtenOn": "2024-04-29T20:24:30Z",
"side": 1,
"message": "Remove",
"range": {
"startLine": 582,
"startChar": 0,
"endLine": 582,
"endChar": 32
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a5cac4aa_b7db4ff8",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 582,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "c4cb6293_f3e60a33",
"range": {
"startLine": 582,
"startChar": 0,
"endLine": 582,
"endChar": 32
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "da84ac16_97a25b90",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 593,
"author": {
"id": 36476
},
"writtenOn": "2024-04-29T20:24:30Z",
"side": 1,
"message": "Why are you mocking the json dumps?",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5e6ccf9c_02f3d7d2",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 593,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "removed it, since UT works without json.dumps mocking.",
"parentUuid": "da84ac16_97a25b90",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2ac69ce5_f4fdfbc2",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 637,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "test_get_peer_system_list_with_unavailable_peer",
"range": {
"startLine": 637,
"startChar": 8,
"endLine": 637,
"endChar": 33
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "35f34ff9_65131f38",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 662,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "This test needs to verify that the run_deploy_phases function properly executes each phase with the **correct order** successfully (returning True). My suggestion is to mock the subcloud_deploy_\u003c\u003e functions and pass a deploy_phases_to_run list containing all states except one and in a random order, then assert that the subcloud_deploy functions where called in the correct order.\n\nThen have a separate test where one of the inner functions returns false to indicate a failure and then assert that the run_deploy_phases also returns false.",
"range": {
"startLine": 654,
"startChar": 0,
"endLine": 662,
"endChar": 9
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "51726334_040d3a57",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 666,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "Please add another test to verify the success case, where the subcloud backup status is set to \u0027validate-failed\u0027.",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cb26d4da_c3da6a4d",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 690,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "DEPLOY_STATE_RECONFIGURING_NETWORK",
"range": {
"startLine": 690,
"startChar": 48,
"endLine": 690,
"endChar": 65
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cfa8e139_aa83311e",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 719,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "Suggestion: loop over the payload to do the assertions, you should be able to access the updated_subcloud as if it was a dictionary (so you can use the payload key).",
"range": {
"startLine": 708,
"startChar": 0,
"endLine": 719,
"endChar": 60
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1c1c145f_5156ffbc",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 720,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "Add another assertion to verify that the deploy_status was updated to DEPLOY_STATE_DONE",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d44bfe05_2460209b",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 725,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "DEPLOY_STATE_RECONFIGURING_NETWORK",
"range": {
"startLine": 725,
"startChar": 48,
"endLine": 725,
"endChar": 72
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1e59f2b7_e3216858",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 730,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "Also assert that the subcloud deploy_status was updated to DEPLOY_STATE_RECONFIGURING_NETWORK_FAILED",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5bffa324_09ef772b",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 741,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "configure_system_controller_network",
"range": {
"startLine": 741,
"startChar": 13,
"endLine": 741,
"endChar": 27
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b20c76f0_b0a3d729",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 744,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "DEPLOY_STATE_RECONFIGURING_NETWORK",
"range": {
"startLine": 744,
"startChar": 48,
"endLine": 744,
"endChar": 65
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1af78281_467b0406",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 761,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "Use the assert_not_called() method.",
"range": {
"startLine": 761,
"startChar": 8,
"endLine": 761,
"endChar": 50
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "53241f78_c271cb3f",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 773,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "DEPLOY_STATE_RECONFIGURING_NETWORK",
"range": {
"startLine": 773,
"startChar": 48,
"endLine": 773,
"endChar": 65
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "72bf7583_eb9b9b0d",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 784,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "Use the assert_not_called() method.",
"range": {
"startLine": 784,
"startChar": 8,
"endLine": 784,
"endChar": 50
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "04743e57_56f827ec",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 787,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "Please add a new assertion to verify that the subcloud deploy_status was updated to DEPLOY_STATE_RECONFIGURING_NETWORK_FAILED",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "904477d4_b32fcebb",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 794,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:02:38Z",
"side": 1,
"message": "DEPLOY_STATE_RECONFIGURING_NETWORK",
"range": {
"startLine": 794,
"startChar": 48,
"endLine": 794,
"endChar": 65
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3b7ab7c9_f4cdb08e",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 3850,
"author": {
"id": 36476
},
"writtenOn": "2024-04-29T20:24:30Z",
"side": 1,
"message": "Please, work on this class\u0027 code duplication",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f0863457_e0b7b129",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 3850,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "3b7ab7c9_f4cdb08e",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink