696 lines
21 KiB
Plaintext
696 lines
21 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5e03f7a9_46686e64",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 39,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "If there isn\u0027t another file with the same name, I\u0027d suggest maintaining the original instead of changing it like this.",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "91082dd4_dfcef2b8",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 39,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "5e03f7a9_46686e64",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0f3c19ea_1ef99a35",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 455,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "There\u0027s a method in base called mock_log. Please use it instead of creating a new one,",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6171865b_cfbba215",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 455,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "0f3c19ea_1ef99a35",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "624bf640_8867769b",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 558,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "Except for the subcloud inventory, all of the other lines are duplicated in the test cases above",
|
|
"range": {
|
|
"startLine": 551,
|
|
"startChar": 0,
|
|
"endLine": 558,
|
|
"endChar": 68
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "990d0596_682007f7",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 558,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "624bf640_8867769b",
|
|
"range": {
|
|
"startLine": 551,
|
|
"startChar": 0,
|
|
"endLine": 558,
|
|
"endChar": 68
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6a9ab158_918b50c6",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 567,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "The subcloud creation is duplicated in all of the new test cases created above. This means that it should be in the class\u0027 setup",
|
|
"range": {
|
|
"startLine": 564,
|
|
"startChar": 0,
|
|
"endLine": 567,
|
|
"endChar": 72
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "79d06019_dab1013a",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 567,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "6a9ab158_918b50c6",
|
|
"range": {
|
|
"startLine": 564,
|
|
"startChar": 0,
|
|
"endLine": 567,
|
|
"endChar": 72
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0f858784_0ca58f7f",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 572,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "Inside the base class, there shouldn\u0027t be any test cases. Otherwise, they\u0027ll be executed in all of the other classes",
|
|
"range": {
|
|
"startLine": 511,
|
|
"startChar": 3,
|
|
"endLine": 572,
|
|
"endChar": 49
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e11f7e9d_ff4f65a5",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 572,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "created new class TestSubcloudManager and moved them to TestSubcloudManager",
|
|
"parentUuid": "0f858784_0ca58f7f",
|
|
"range": {
|
|
"startLine": 511,
|
|
"startChar": 3,
|
|
"endLine": 572,
|
|
"endChar": 49
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b76bed27_5379fc11",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 920,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "This subcloud creation is duplicated in the tests above. It could be instantiated in the class\u0027 setup method",
|
|
"range": {
|
|
"startLine": 917,
|
|
"startChar": 0,
|
|
"endLine": 920,
|
|
"endChar": 57
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9124745f_55d6aa4b",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 920,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "b76bed27_5379fc11",
|
|
"range": {
|
|
"startLine": 917,
|
|
"startChar": 0,
|
|
"endLine": 920,
|
|
"endChar": 57
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "43af56fb_fd3e921d",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 935,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "In this case, you could update the subcloud in the database once the creation is in setup",
|
|
"range": {
|
|
"startLine": 932,
|
|
"startChar": 0,
|
|
"endLine": 935,
|
|
"endChar": 72
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "daca8db4_4bdeb2e0",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 935,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "43af56fb_fd3e921d",
|
|
"range": {
|
|
"startLine": 932,
|
|
"startChar": 0,
|
|
"endLine": 935,
|
|
"endChar": 72
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "13efc80e_b5a55b44",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2233,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "This is duplicated in many test cases, you could mock the builtins open in the base class setup since it\u0027s a function that should never be truly executed.",
|
|
"range": {
|
|
"startLine": 2233,
|
|
"startChar": 0,
|
|
"endLine": 2233,
|
|
"endChar": 34
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "aba63c82_745041d4",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2233,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "adding in base class setup effects test_update_subcloud_identity_endpoint with below error\n fcntl.lockf(self.lockfile, fcntl.LOCK_EX | fcntl.LOCK_NB)\nTypeError: fileno() returned a non-integer",
|
|
"parentUuid": "13efc80e_b5a55b44",
|
|
"range": {
|
|
"startLine": 2233,
|
|
"startChar": 0,
|
|
"endLine": 2233,
|
|
"endChar": 34
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c91294cf_657d371a",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2236,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "Avoid using the FakeException. Instead use Exception or any other relevant class here.\nThe FakeException will be removed soon.\nThis also applies to other places in this file",
|
|
"range": {
|
|
"startLine": 2236,
|
|
"startChar": 38,
|
|
"endLine": 2236,
|
|
"endChar": 51
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "1b1ed4f9_b07b60e8",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2236,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "c91294cf_657d371a",
|
|
"range": {
|
|
"startLine": 2236,
|
|
"startChar": 38,
|
|
"endLine": 2236,
|
|
"endChar": 51
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e0dcdc86_42158df7",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2244,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "Create a method to return this data and call it in the new test cases below",
|
|
"range": {
|
|
"startLine": 2237,
|
|
"startChar": 7,
|
|
"endLine": 2244,
|
|
"endChar": 46
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7c0a5c82_8620056e",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2244,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "e0dcdc86_42158df7",
|
|
"range": {
|
|
"startLine": 2237,
|
|
"startChar": 7,
|
|
"endLine": 2244,
|
|
"endChar": 46
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cbcd2f54_ae43a8bd",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2486,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "There\u0027s another case in the delete command in which it adds the inventory_hostname to the command. Is that already covered? If not, can you create it, please?",
|
|
"range": {
|
|
"startLine": 2471,
|
|
"startChar": 0,
|
|
"endLine": 2486,
|
|
"endChar": 0
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "100b9e7a_9e5db2b8",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2486,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "yes it was covered, test_compose_backup_delete_command_backup_stored_in_central_storage",
|
|
"parentUuid": "cbcd2f54_ae43a8bd",
|
|
"range": {
|
|
"startLine": 2471,
|
|
"startChar": 0,
|
|
"endLine": 2486,
|
|
"endChar": 0
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c3622cd1_aeaf4b5f",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2652,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "I\u0027m seeing this duplicated in the code also. Maybe it can be instantiated and mocked in the base class to simplify the test cases",
|
|
"range": {
|
|
"startLine": 2651,
|
|
"startChar": 0,
|
|
"endLine": 2652,
|
|
"endChar": 51
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "23d749a6_fe88a4c2",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2652,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "c3622cd1_aeaf4b5f",
|
|
"range": {
|
|
"startLine": 2651,
|
|
"startChar": 0,
|
|
"endLine": 2652,
|
|
"endChar": 51
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "44f14377_52ebc411",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2659,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "Most of the methods in backup creates the subcloud like this. Move it to the class\u0027 setup and update what\u0027s necessary to each test case only.\nAlso the update below can be moved to the setup to further simplify",
|
|
"range": {
|
|
"startLine": 2656,
|
|
"startChar": 0,
|
|
"endLine": 2659,
|
|
"endChar": 51
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "706e0767_975a2d07",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2659,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "44f14377_52ebc411",
|
|
"range": {
|
|
"startLine": 2656,
|
|
"startChar": 0,
|
|
"endLine": 2659,
|
|
"endChar": 51
|
|
},
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1fc771f8_5ebae96b",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2685,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "Use FAKE_SW_VERSION and call it directly in the line below",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8dde2674_eaad4f44",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2685,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "1fc771f8_5ebae96b",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b8d79b20_d3c99f22",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2696,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "Is it really necessary to mock the join? If that is, probably there\u0027s an error in another mock since the os.join simply concatenates two strings together",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0f4fbfc2_22ef72e8",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 2696,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "below is trace and added mock_log.error\ndef create_subcloud_backups\n\tdef _backup_subcloud\n\t\tdef _run_subcloud_backup_create_playbook --\u003e 1821\t\n\t\t\tdef _fail_subcloud_backup_operation\n\t\t\t\tbackup_status\u003dconsts.BACKUP_STATE_FAILED,",
|
|
"parentUuid": "b8d79b20_d3c99f22",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1212b5c5_9d37c9c3",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 3370,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-19T12:48:43Z",
|
|
"side": 1,
|
|
"message": "Add a line break after the documentation to separate it from the code below",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a1fefc42_f2989d73",
|
|
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 3370,
|
|
"author": {
|
|
"id": 35809
|
|
},
|
|
"writtenOn": "2024-04-22T12:19:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "1212b5c5_9d37c9c3",
|
|
"revId": "a4ec1365e776893b9d90b3ed525b9914093a10b3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |