From cc3efc6588b7f4ad2ceb9fa3de5774149e1af01b Mon Sep 17 00:00:00 2001 From: Saul Wold Date: Wed, 13 May 2020 08:26:45 -0700 Subject: [PATCH] Add TIS_PATCH_VER info to submmision guide This is being added to reminder developers about the need to update this variable to prevent build and package installation breakage. Change-Id: Id96409989b58a636dd4ca507a5191065be89d09e Signed-off-by: Saul Wold --- doc/source/developer_resources/code-submission-guide.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/source/developer_resources/code-submission-guide.rst b/doc/source/developer_resources/code-submission-guide.rst index 5b59c0e46..320d5c7ec 100644 --- a/doc/source/developer_resources/code-submission-guide.rst +++ b/doc/source/developer_resources/code-submission-guide.rst @@ -89,6 +89,10 @@ Pre-review and pre-submission testing * For the majority of cases, it is expected that the author completes their testing before posting a review. * Make sure the new code compiles and builds successfully. +* For each package being modified, update the ``TIS_PATCH_VER`` variable in + the centos/build_srpm.data. This ensures that packages are versioned + correctly and the latest version will be used. If up-versioning a + package then reset ``TIS_PATCH_VER`` to 0. * Run tox tests (flake8, py27, etc) successfully. These can all be run manually prior to launching a review. * Update existing automated unit tests and add new ones when applicable.