From 72c49a1abf6978423ee61cbbbb644786df5929ac Mon Sep 17 00:00:00 2001 From: Gerrit User 9926 <9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 29 Sep 2022 15:53:51 +0000 Subject: [PATCH] Update patch set 4 Patch Set 4: (1 comment) Patch-set: 4 Reviewer: Gerrit User 28676 <28676@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Attention: {"person_ident":"Gerrit User 15435 \u003c15435@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 28676 \u003c28676@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"} --- 74d56e72a05a21bcb1ef6d7e33516e8ee4414fee | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/74d56e72a05a21bcb1ef6d7e33516e8ee4414fee b/74d56e72a05a21bcb1ef6d7e33516e8ee4414fee index 27b60c13..3b5a0e48 100644 --- a/74d56e72a05a21bcb1ef6d7e33516e8ee4414fee +++ b/74d56e72a05a21bcb1ef6d7e33516e8ee4414fee @@ -68,6 +68,24 @@ "message": "This change seems safe.\n\nIt looks like its only really called a small number of places.\nOne place on Debian is /usr/bin/kube-cert-rotation.sh\nwhich looks like it is not even executable.\n\n-rw-r--r-- 3 root root 10718 Jan 1 1970 /usr/bin/kube-cert-rotation.sh\n\na minor followup. We copy/pasted a section of this Makefile as a documentation example here:\nhttps://opendev.org/starlingx/docs/src/branch/master/doc/source/developer_resources/packaging_ref.rst\n\nSo probably we should update that as well, although it doesnt really matter.\n\n", "revId": "74d56e72a05a21bcb1ef6d7e33516e8ee4414fee", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "67a45152_ca5537ee", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 4 + }, + "lineNbr": 0, + "author": { + "id": 9926 + }, + "writtenOn": "2022-09-29T15:53:51Z", + "side": 1, + "message": "I believe kube-cert-rotation.sh is to be run by sysadmin. +Andy to confirm", + "parentUuid": "c3bbf549_eaeced33", + "revId": "74d56e72a05a21bcb1ef6d7e33516e8ee4414fee", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file