The rpmlintrc files helps to configure the behavior of the rpm linter
executed by the opensuse build system. This patch adds the rpmlintrc
files that were defined in the opensuse build system.
Story: 2006508
Task: 36799
Change-Id: If75264e809bb78bbcff1dd474b1a5fc1819ac193
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
In the opensuse build system (OBS) the `_service` files are being
standardized to generate tarballs with gz compression. The fault's
specfiles were created before this decision, therefore an update
in the extension is required.
Story: 2006508
Task: 36670
Change-Id: I96cb185a9a0e089e4f8e184e8fdeaa709f77915e
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
Several indentation issues were solved, also some style was applied
to improve code's readability.
cpplint is being used to get all these warnings, however there are
some warnings that were suppressed. This means that this file still
has the following issues:
- line length > 80 characters
- C casting in C++ code
- References that can be const or pointers
These issues will be solved in a next iteration as are more intrusive
with the code.
No functionality changes were done.
Story: 2006425
Task: 36322
Change-Id: I4a2d3bcf9a13e0ce2659cc9a8211fc727b34d80e
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
Several indentation issues were solved, also some style was applied
to improve code's readability.
No functionality changes were done.
Story: 2006425
Task: 36322
Change-Id: I908ce18cb68ddcb96239866e720a82757a058691
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
fm-api already has a LICENSE file no need to copy LICENSE in
Closes-Bug: 1842667
Change-Id: I9232e73f4d38394ad7d427431d0b766c1fbadf5b
Signed-off-by: Saul Wold <sgw@linux.intel.com>
This moves the linters to use the zuul-jobs
Remove the old flock-check-packaging
Depends-On: https://review.opendev.org/#/c/679353
Change-Id: I5abc8dd461e2728d43eddc528f23d940fc45a32a
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Several indentation issues were solved, also some style was applied
to improve code's readability.
No funcionality changes were done.
Story: 2006425
Task: 36322
Change-Id: Ie3339ed10254a053a2e26397337c45dfa2d552bd
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
This commit adds a "pending application reapply" alarm to fm,
which will be raised when there has been a configuration change
to nodes that affects the helm overrides.
Partial-Bug: 1837750
Change-Id: Iec5852a798eee51dacbc5ea5016e4c20d85b668c
Signed-off-by: Tyler Smith <tyler.smith@windriver.com>
Use templates instead of individual jobs so that these
can be changed in one place.
Depends-On: https://review.opendev.org/677606
Change-Id: If47727858f1a2bef239be5ec400f4447b09f4722
The Customer Log Table was removed in a prior change and the customer
log MIB object identifiers are no longer available. This change replaces
the customer log identifiers with the event identifiers.
Change-Id: Ia8a9c5250744f4206d57c309d26c9398ff01fcba
Closes-Bug: 1828453
Signed-off-by: David Sullivan <david.sullivan@windriver.com>
In this commit, the Management_Affecting_Severity is
changed from none to warning for 2 types of k8s app alarms:
- Application Apply In Progress (alarm id: 750.004) and
- Application Update In Progress (alarm id: 750.005)
This change will disallow a patch or upgrade while any
of these alarms exists.
The Degrade_Affecting_Severity setting will remain to
be 'none' for all app alarms as logically these events
should not degrade the host to the point of disabling
filesystem resizing or controller swact.
Closes-Bug: 1833323
Change-Id: Ie5a85bb4480f8ce6dcb63dfd2e26dacdbceeb366
Signed-off-by: Tee Ngo <Tee.Ngo@windriver.com>
This commit is a follow up of the previous commit
b4c088c6a4 which missed
some fields for fm-doc compile.
Closes-Bug: 1833323
Change-Id: I80e42ea49d1e69ac3d6b199a1b26dfb7c977dd1f
Signed-off-by: Tee Ngo <Tee.Ngo@windriver.com>
The newly introduced fault constants will be used to raise and
clear application related alarms.
Closes-Bug: 1833323
Change-Id: I992ab7a788cfab8d52d2e6a498519c591148f588
Signed-off-by: Tee Ngo <Tee.Ngo@windriver.com>
This is a tox job to scan the RPM specfiles and do some
initial sanity checks and use the OpenDev Spec-Cleaner tool, this
is not a 'linter' per-se, but will output a diff of recommended
changes for the specfile.
Initial disable cleaning our default CentOS specfiles since we
know they need work, we can enable this later.
This uses the speclint script in starlingx/integ a proposed
by the Depends-On.
The recommended guildline for openSUSE is located here:
https://en.opensuse.org/openSUSE:Specfile_guidelines
Fix up fm-rest-api opensuse specfile
Depends-On: https://review.opendev.org/664995
Change-Id: I46da780a667569a9dccedd551d955c983e9601cd
Signed-off-by: Saul Wold <sgw@linux.intel.com>
The storyboard and gerrit doc link are error, and git library
redirect to the correct one, this change is to correct all them.
Change-Id: I4b74c76007faf491d9c48a42c49702f388c87c98
Partial-Bug: #1835207
Signed-off-by: junboli <junbo85.li@gmail.com>
This commit adds the RPM specfile that supports openSUSE, these
include the _service file which creates the tarball, the changes
files and specfile itself.
These are all built via the OpenBuildService (OBS) and can be
found here:
https://build.opensuse.org/project/show/Cloud:StarlingX:2.0
Change-Id: I676aae8cb9554eab2740232fd0dd77e0ed876506
Signed-off-by: Saul Wold <sgw@linux.intel.com>
This commit documents an overview in order to give a general idea
about what is Fault Management service and what is the role in
StarlingX project.
Story: 2005863
Task: 33669
Change-Id: Id58385cabc9c656aa03132a42f39d9663a6be08e
Signed-off-by: Mario Alfredo Carrillo Arevalo <mario.alfredo.c.arevalo@intel.com>
The dependency resolver for RPM relies on the shebang to have the
interperter that will be used in order to get things right, so
change shebang to /usr/bin/python.
In other cases, the shebang is not needed at all as these are not
really executable python files, they are part of the python package.
RPMLINT finds these and complains that a non-executable has a shebang.
Change-Id: Ie90a846d6addffca1225e59fd8b6f3753d2991a4
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Add control and rules files to generate fm-mgr deb following
StarlingX/MultiOS/Debian Wiki.
Change-Id: I00d5684373c863e8b891816f1228c96b51641f61
Story: 2004792
Task: 33570
Signed-off-by: Marcela Rosales <marcela.a.rosales.jimenez@intel.com>
The Maintainer was change from a proper name to the StarlingX
project as it can be confusing the responsibilities of the person.
Change-Id: I32faf658388bc38e248362c71589f70f8f22ad4d
Story:2004792
Signed-off-by: Marcela Rosales <marcela.a.rosales.jimenez@intel.com>
Flake8 currently ignores the following errors:
H233: Python 3.x incompatible use of print operator
H236: Python 3.x incompatible __metaclass__
H238: Old style class declaration, use new style
Enable them for python3 compability
Change-Id: I8959f3a78ce683eb93a16234908662189dd7c8a5
Story: 2004515
Task: 29304
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Add control and rules files to generate fm-rest-api deb following
StarlingX/MultiOS/Debian Wiki.
Change-Id: Iad365e637269029cf7a371e29362dda0648a1ba9
Story: 2004792
Task: 33571
Signed-off-by: Marcela Rosales <marcela.a.rosales.jimenez@intel.com>
Add control and rules files to generate fm-api deb following
StarlingX/MultiOS/Debian Wiki.
Change-Id: I5a113e070c73273754efb8c4846d05ba6a25e19f
Story: 2004792
Task: 33572
Signed-off-by: Marcela Rosales <marcela.a.rosales.jimenez@intel.com>
This commit implements the methods PUT and POST in order
to insert and update alarms.
Story: 2004008
Task: 30270
Change-Id: I773e651165b3654684b95463167fc565aef1ffa4
Co-authored-by: Sun Austin <austin.sun@intel.com>
Signed-off-by: Mario Alfredo Carrillo Arevalo <mario.alfredo.c.arevalo@intel.com>
Signed-off-by: Sun Austin <austin.sun@intel.com>
This fixes two issues
-Alarm clear time incorrectly reported on non-UTC systems.
-Paused instances do not display the correct alarm timestamp in
non-UTC systems.
The mktime call that's made in fm_db_util_get_timestamp uses the local
tz in it's calculation. It assumes the incoming time is also in the
local time. When mktime is provided with a value in UTC we see the error
presented in this bug.
Change-Id: Iaf8d097e2dfdfae585b6976e02a85b9e2f1b19f9
Closes-Bug: 1828448
Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>
Since fm-mgr uses logrotate servce, it should be a dependency.
Build Tested and confirmed that logrotate was a Required by both
inspection of SRPM and via rpm -q fm-mgr-1.0-6.tis.x86_64.rpm --requires
Change-Id: I55d005d3071ee0511a7404c5e7fd0389a92b2d0c
Signed-off-by: Saul Wold <sgw@linux.intel.com>
These functions do a number of things, specifically they handles the
DevStack USE_PYTHON3 switch transparently so we can run both major
Python versions.
The new setup.cfg files are only used by setup_*() right now, making
the switch to use pbr is beyond what I want to do here.
Change-Id: Ib9753119235b1ce23030a2b3de0169ed6f8819e0
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
It is required for the fminit header to be compliant with LSB in
order to build on OBS infrastructure.
Story: 2003736
Task: 31057
Change-Id: I70555ce7b1245c940d56a04aa98bd1a5c17dc04e
Signed-off-by: Marcela Rosales <marcela.a.rosales.jimenez@intel.com>
Erich Cordoba