{ "comments": [ { "unresolved": true, "key": { "uuid": "76d37e18_3a5b7434", "filename": "fm-doc/fm_doc/events.yaml", "patchSetId": 3 }, "lineNbr": 3665, "author": { "id": 9926 }, "writtenOn": "2024-04-24T18:19:04Z", "side": 1, "message": "This would probably be more suitable as a type \u0027Log\u0027 since alarms generally indicate an issue requiring immediate attention", "range": { "startLine": 3665, "startChar": 10, "endLine": 3665, "endChar": 15 }, "revId": "5e0f635c6bbaaf8d7434f2ede51a93b9006b85ef", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "bfdbddd1_5547eb12", "filename": "fm-doc/fm_doc/events.yaml", "patchSetId": 3 }, "lineNbr": 3665, "author": { "id": 33390 }, "writtenOn": "2024-04-24T21:04:30Z", "side": 1, "message": "I\u0027ve tested it, but set as Log it does not show on the alarm list, which is what I want, so it\u0027s better to leave it set as Alarm.", "parentUuid": "76d37e18_3a5b7434", "range": { "startLine": 3665, "startChar": 10, "endLine": 3665, "endChar": 15 }, "revId": "5e0f635c6bbaaf8d7434f2ede51a93b9006b85ef", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "d602a5d4_b25623d2", "filename": "fm-doc/fm_doc/events.yaml", "patchSetId": 3 }, "lineNbr": 3665, "author": { "id": 9926 }, "writtenOn": "2024-04-25T13:44:08Z", "side": 1, "message": "A log would appear in \u0027fm event-list\u0027 though it wouldnt have a state of raised/cleared that an alarm would. \n\nGenerally alarms should be for fault conditions that may require admin/customer attention. Ideally, the service should be able to retrieve its service state without dependency on fm.", "parentUuid": "bfdbddd1_5547eb12", "range": { "startLine": 3665, "startChar": 10, "endLine": 3665, "endChar": 15 }, "revId": "5e0f635c6bbaaf8d7434f2ede51a93b9006b85ef", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "7444c797_648486ab", "filename": "fm-doc/fm_doc/events.yaml", "patchSetId": 3 }, "lineNbr": 3665, "author": { "id": 33390 }, "writtenOn": "2024-04-25T15:20:01Z", "side": 1, "message": "As a recommendation from @bin.qian@windriver.com I changed the severity of the alarm to warning. I still prefer it as an alarm and not as a log because after deploy host is completed it needs an user action, which is to unlock the host.", "parentUuid": "d602a5d4_b25623d2", "range": { "startLine": 3665, "startChar": 10, "endLine": 3665, "endChar": 15 }, "revId": "5e0f635c6bbaaf8d7434f2ede51a93b9006b85ef", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] }