0ccc66ab6a
Patch Set 7:
(2 comments)
Patch-set: 7
Attention: {"person_ident":"Gerrit User 32852 \u003c32852@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32241\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32241 \u003c32241@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32241\u003e replied on the change"}
115 lines
3.0 KiB
Plaintext
115 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6e7a8e61_caa919bd",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 32852
|
|
},
|
|
"writtenOn": "2023-10-19T17:54:28Z",
|
|
"side": 1,
|
|
"message": "Just a small rewording",
|
|
"revId": "a9448c0131537e8ad1859e3b9747f7c8608b1af4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0d713202_2f56f561",
|
|
"filename": "fm-common/sources/fmAPI.cpp",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 116,
|
|
"author": {
|
|
"id": 32852
|
|
},
|
|
"writtenOn": "2023-10-19T17:54:28Z",
|
|
"side": 1,
|
|
"message": "nit: Trying.\nI would write this log message as:\n\"Invalid file descriptor. Attempting to reconnect...\"",
|
|
"range": {
|
|
"startLine": 116,
|
|
"startChar": 22,
|
|
"endLine": 116,
|
|
"endChar": 53
|
|
},
|
|
"revId": "a9448c0131537e8ad1859e3b9747f7c8608b1af4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e0a72cac_9544d461",
|
|
"filename": "fm-common/sources/fmAPI.cpp",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 116,
|
|
"author": {
|
|
"id": 32241
|
|
},
|
|
"writtenOn": "2023-10-19T18:02:03Z",
|
|
"side": 1,
|
|
"message": "Updated. Thank you Enzo!",
|
|
"parentUuid": "0d713202_2f56f561",
|
|
"range": {
|
|
"startLine": 116,
|
|
"startChar": 22,
|
|
"endLine": 116,
|
|
"endChar": 53
|
|
},
|
|
"revId": "a9448c0131537e8ad1859e3b9747f7c8608b1af4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "044ae4f8_69a731e7",
|
|
"filename": "fm-common/sources/fmSocket.cpp",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 270,
|
|
"author": {
|
|
"id": 32852
|
|
},
|
|
"writtenOn": "2023-10-19T17:54:28Z",
|
|
"side": 1,
|
|
"message": "I would reword this to something like:\n\"A broken pipe error occurred\"",
|
|
"range": {
|
|
"startLine": 270,
|
|
"startChar": 17,
|
|
"endLine": 270,
|
|
"endChar": 34
|
|
},
|
|
"revId": "a9448c0131537e8ad1859e3b9747f7c8608b1af4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a628bf38_2fd50586",
|
|
"filename": "fm-common/sources/fmSocket.cpp",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 270,
|
|
"author": {
|
|
"id": 32241
|
|
},
|
|
"writtenOn": "2023-10-19T18:02:03Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "044ae4f8_69a731e7",
|
|
"range": {
|
|
"startLine": 270,
|
|
"startChar": 17,
|
|
"endLine": 270,
|
|
"endChar": 34
|
|
},
|
|
"revId": "a9448c0131537e8ad1859e3b9747f7c8608b1af4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |