91 lines
3.0 KiB
Plaintext
91 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d2d7e14c_cd44834f",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33487
|
|
},
|
|
"writtenOn": "2022-09-28T14:30:23Z",
|
|
"side": 1,
|
|
"message": "Ready to review.",
|
|
"revId": "74d56e72a05a21bcb1ef6d7e33516e8ee4414fee",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "510b42e0_5c706b35",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 21776
|
|
},
|
|
"writtenOn": "2022-09-28T19:41:38Z",
|
|
"side": 1,
|
|
"message": "looks good. Did you check that you can still create alarms with the existing admin user?",
|
|
"revId": "74d56e72a05a21bcb1ef6d7e33516e8ee4414fee",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5e0df5d8_36b0d6c1",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33487
|
|
},
|
|
"writtenOn": "2022-09-28T19:51:41Z",
|
|
"side": 1,
|
|
"message": "Yes, alarms are created using sysadmin with no problems.",
|
|
"parentUuid": "510b42e0_5c706b35",
|
|
"revId": "74d56e72a05a21bcb1ef6d7e33516e8ee4414fee",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c3bbf549_eaeced33",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 15435
|
|
},
|
|
"writtenOn": "2022-09-29T13:31:42Z",
|
|
"side": 1,
|
|
"message": "This change seems safe.\n\nIt looks like its only really called a small number of places.\nOne place on Debian is /usr/bin/kube-cert-rotation.sh\nwhich looks like it is not even executable.\n\n-rw-r--r-- 3 root root 10718 Jan 1 1970 /usr/bin/kube-cert-rotation.sh\n\na minor followup. We copy/pasted a section of this Makefile as a documentation example here:\nhttps://opendev.org/starlingx/docs/src/branch/master/doc/source/developer_resources/packaging_ref.rst\n\nSo probably we should update that as well, although it doesnt really matter.\n\n",
|
|
"revId": "74d56e72a05a21bcb1ef6d7e33516e8ee4414fee",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "67a45152_ca5537ee",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2022-09-29T15:53:51Z",
|
|
"side": 1,
|
|
"message": "I believe kube-cert-rotation.sh is to be run by sysadmin. +Andy to confirm",
|
|
"parentUuid": "c3bbf549_eaeced33",
|
|
"revId": "74d56e72a05a21bcb1ef6d7e33516e8ee4414fee",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |