85e52e7862
Patch Set 1: Code-Review+2
(1 comment)
Patch-set: 1
Reviewer: Gerrit User 9926 <9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 320d2e60be96a70a7159c7dc6b2ed578c940be04
Attention: {"person_ident":"Gerrit User 28676 \u003c28676@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
140 lines
4.3 KiB
Plaintext
140 lines
4.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f7119791_e28664ca",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28676
|
|
},
|
|
"writtenOn": "2024-03-15T15:02:42Z",
|
|
"side": 1,
|
|
"message": "The alarm will prevent nfv system config update operation. So hold off the change until it is addressed.",
|
|
"revId": "e0c18256357f167ff3c13975ecf9ede48dbb8b06",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3e5e41cf_1e467766",
|
|
"filename": "fm-doc/fm_doc/events.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 1012,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-03-14T21:11:37Z",
|
|
"side": 1,
|
|
"message": "this will stop nfv orchestration, unless it\u0027s in the nfv alarm ignore list , please confirm this is expected? https://opendev.org/starlingx/nfv/src/commit/bac2f0a09e35526e0e6cdb6f1b11cde8c848c043/nfv/nfv-vim/nfv_vim/strategy/_strategy.py#L2341",
|
|
"range": {
|
|
"startLine": 1012,
|
|
"startChar": 35,
|
|
"endLine": 1012,
|
|
"endChar": 42
|
|
},
|
|
"revId": "e0c18256357f167ff3c13975ecf9ede48dbb8b06",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7d32ca29_7a1fed46",
|
|
"filename": "fm-doc/fm_doc/events.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 1012,
|
|
"author": {
|
|
"id": 28676
|
|
},
|
|
"writtenOn": "2024-03-15T14:32:29Z",
|
|
"side": 1,
|
|
"message": "Good point. I think this alarm should be in the nfv ignore list, because it shouldn\u0027t prevent a system config update operation. And I think we should ignore 250.003 as well.",
|
|
"parentUuid": "3e5e41cf_1e467766",
|
|
"range": {
|
|
"startLine": 1012,
|
|
"startChar": 35,
|
|
"endLine": 1012,
|
|
"endChar": 42
|
|
},
|
|
"revId": "e0c18256357f167ff3c13975ecf9ede48dbb8b06",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4c56fb30_65e6c5d7",
|
|
"filename": "fm-doc/fm_doc/events.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 1012,
|
|
"author": {
|
|
"id": 28676
|
|
},
|
|
"writtenOn": "2024-03-15T14:47:38Z",
|
|
"side": 1,
|
|
"message": "Hi @John Kung, how to test a nfv system config update operation?",
|
|
"parentUuid": "7d32ca29_7a1fed46",
|
|
"range": {
|
|
"startLine": 1012,
|
|
"startChar": 35,
|
|
"endLine": 1012,
|
|
"endChar": 42
|
|
},
|
|
"revId": "e0c18256357f167ff3c13975ecf9ede48dbb8b06",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "251e3d25_81f9cf94",
|
|
"filename": "fm-doc/fm_doc/events.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 1012,
|
|
"author": {
|
|
"id": 28676
|
|
},
|
|
"writtenOn": "2024-03-18T21:29:41Z",
|
|
"side": 1,
|
|
"message": "Hi @John Kung, I rethink about this. I think if ipsec certs renewal fails, it means something goes wrong, it\u0027s better to fix the error condition before allowing nfv to orchestrating changes to the system. So we will let this alarm to prevent the operation. Do you agree?",
|
|
"parentUuid": "4c56fb30_65e6c5d7",
|
|
"range": {
|
|
"startLine": 1012,
|
|
"startChar": 35,
|
|
"endLine": 1012,
|
|
"endChar": 42
|
|
},
|
|
"revId": "e0c18256357f167ff3c13975ecf9ede48dbb8b06",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "eadd6e09_84128926",
|
|
"filename": "fm-doc/fm_doc/events.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 1012,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-03-20T20:40:53Z",
|
|
"side": 1,
|
|
"message": "ok, the underlying condition would need to be addressed before allowing nfv orch",
|
|
"parentUuid": "251e3d25_81f9cf94",
|
|
"range": {
|
|
"startLine": 1012,
|
|
"startChar": 35,
|
|
"endLine": 1012,
|
|
"endChar": 42
|
|
},
|
|
"revId": "e0c18256357f167ff3c13975ecf9ede48dbb8b06",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |