4f4ca5e41f
Patch Set 4: Code-Review-1 (1 comment) Patch-set: 4 Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, e5728dc43de6c5669666b382a05b71baf7b51b35 Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 34895 \u003c34895@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
51 lines
1.4 KiB
Plaintext
51 lines
1.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ce881cb9_0e01482d",
|
|
"filename": "fm-doc/fm_doc/events.yaml",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3953,
|
|
"author": {
|
|
"id": 33390
|
|
},
|
|
"writtenOn": "2024-03-19T17:57:47Z",
|
|
"side": 1,
|
|
"message": "nit: It is not clear to me when to use these \"Actions\" and how they are displayed, but I see the alarms below using Proposed_Repair_Action instead.",
|
|
"range": {
|
|
"startLine": 3952,
|
|
"startChar": 4,
|
|
"endLine": 3953,
|
|
"endChar": 135
|
|
},
|
|
"revId": "368a856f4c34ec24fc743f88708c4f9e0e9dbc14",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d6a207d5_0482e7fe",
|
|
"filename": "fm-doc/fm_doc/events.yaml",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3953,
|
|
"author": {
|
|
"id": 28464
|
|
},
|
|
"writtenOn": "2024-03-22T13:39:51Z",
|
|
"side": 1,
|
|
"message": "Yes, the action string should be associated with the \u0027Proposed_Repair_Action\u0027 field.",
|
|
"parentUuid": "ce881cb9_0e01482d",
|
|
"range": {
|
|
"startLine": 3952,
|
|
"startChar": 4,
|
|
"endLine": 3953,
|
|
"endChar": 135
|
|
},
|
|
"revId": "368a856f4c34ec24fc743f88708c4f9e0e9dbc14",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |