Update patch set 1

Patch Set 1: Code-Review-1 (7 comments) Hi Bruce, Thank you for uploading the initial governance document for review. I added a few comments in line to fix before we merge this version and start iterating on it. Please let me know if you have any question on it. Thanks and Best Regards, Ildikó Patch-set: 1 Label: Code-Review=-1
2018-10-03 11:53:11 +00:00 · 2018-10-03 11:53:11 +00:00 · 30f8a4e643
commit 30f8a4e643
parent cb7dd61099
1 changed files with 165 additions and 0 deletions
--- a/165
+++ b/165
@ -0,0 +1,165 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3f79a3b5_0f78848c",
+        "filename": "starlingX_governance.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 9562
+      },
+      "writtenOn": "2018-10-03T11:53:11Z",
+      "side": 1,
+      "message": "Please align the line length with the text here and below where applicable.",
+      "range": {
+        "startLine": 1,
+        "startChar": 0,
+        "endLine": 1,
+        "endChar": 30
+      },
+      "revId": "9da5c994a27df3940dc7401bff48551a6006d20a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_6f3a58cd",
+        "filename": "starlingX_governance.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 9562
+      },
+      "writtenOn": "2018-10-03T11:53:11Z",
+      "side": 1,
+      "message": "I suggest to add \u0027- DRAFT\u0027 to the title.\n\nWe don\u0027t have the full appointed TSC group yet to approve and there are also some inconsistencies/open question to sort out in the document before we can call it official.",
+      "range": {
+        "startLine": 2,
+        "startChar": 0,
+        "endLine": 2,
+        "endChar": 28
+      },
+      "revId": "9da5c994a27df3940dc7401bff48551a6006d20a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_4f2bdc7a",
+        "filename": "starlingX_governance.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 5,
+      "author": {
+        "id": 9562
+      },
+      "writtenOn": "2018-10-03T11:53:11Z",
+      "side": 1,
+      "message": "Please remove trailing white spaces.",
+      "range": {
+        "startLine": 5,
+        "startChar": 57,
+        "endLine": 5,
+        "endChar": 58
+      },
+      "revId": "9da5c994a27df3940dc7401bff48551a6006d20a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_74878bb7",
+        "filename": "starlingX_governance.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 63,
+      "author": {
+        "id": 9562
+      },
+      "writtenOn": "2018-10-03T11:53:11Z",
+      "side": 1,
+      "message": "As we store documentation in git too we may want to say \u0027code and documentation changes\u0027 here.",
+      "range": {
+        "startLine": 63,
+        "startChar": 85,
+        "endLine": 63,
+        "endChar": 89
+      },
+      "revId": "9da5c994a27df3940dc7401bff48551a6006d20a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_8fc9f479",
+        "filename": "starlingX_governance.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 106,
+      "author": {
+        "id": 9562
+      },
+      "writtenOn": "2018-10-03T11:53:11Z",
+      "side": 1,
+      "message": "I suggest to add a note to the beginning of this section to point to the items pointed out in this thread for further discussion: http://lists.starlingx.io/pipermail/starlingx-discuss/2018-September/001253.html",
+      "range": {
+        "startLine": 106,
+        "startChar": 0,
+        "endLine": 106,
+        "endChar": 28
+      },
+      "revId": "9da5c994a27df3940dc7401bff48551a6006d20a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_cf812cfc",
+        "filename": "starlingX_governance.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 116,
+      "author": {
+        "id": 9562
+      },
+      "writtenOn": "2018-10-03T11:53:11Z",
+      "side": 1,
+      "message": "The lines are supposed to be kept shorter than 80 characters, please cut this line shorter. I think moving the names to a bullet list would also be good for readability.",
+      "range": {
+        "startLine": 116,
+        "startChar": 0,
+        "endLine": 116,
+        "endChar": 204
+      },
+      "revId": "9da5c994a27df3940dc7401bff48551a6006d20a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_ef82e851",
+        "filename": "starlingX_governance.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 118,
+      "author": {
+        "id": 9562
+      },
+      "writtenOn": "2018-10-03T11:53:11Z",
+      "side": 1,
+      "message": "This statement is in conflict with the \u0027fully elected by the Contributors within the first year\u0027 note which is mentioned multiple times in the document. I suggest to add a note to ensure we resolve that before we make the document official.",
+      "range": {
+        "startLine": 118,
+        "startChar": 0,
+        "endLine": 118,
+        "endChar": 55
+      },
+      "revId": "9da5c994a27df3940dc7401bff48551a6006d20a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}