From 8ad96d879cce0ce4ce35bdc10d50097553f794eb Mon Sep 17 00:00:00 2001 From: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 26 Feb 2024 22:03:49 +0000 Subject: [PATCH] Update patch set 8 Patch Set 8: (1 comment) Patch-set: 8 --- a63ea17c1b4ad07488b14384ce8f761032a913fe | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/a63ea17c1b4ad07488b14384ce8f761032a913fe b/a63ea17c1b4ad07488b14384ce8f761032a913fe index cad21f87..9ec3af11 100644 --- a/a63ea17c1b4ad07488b14384ce8f761032a913fe +++ b/a63ea17c1b4ad07488b14384ce8f761032a913fe @@ -111,6 +111,30 @@ }, "revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "1874fa6d_d35acdf1", + "filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py", + "patchSetId": 8 + }, + "lineNbr": 461, + "author": { + "id": 28464 + }, + "writtenOn": "2024-02-26T22:03:49Z", + "side": 1, + "message": "John suggested the following which makes sense\n\n\"the guideline should be if the imports rarely used then it can be within a method; otherwise should be at top of file … since there\u0027s a slight cost to the import\"\n\nIf this code is only run on upgrades then I withdraw my complaint.", + "parentUuid": "ae74cde8_40fb0644", + "range": { + "startLine": 459, + "startChar": 8, + "endLine": 461, + "endChar": 61 + }, + "revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file