From 9f70df63fd0d83bf0f94d1b9ac2f98516d5971c8 Mon Sep 17 00:00:00 2001 From: Bin Qian Date: Fri, 7 May 2021 16:36:23 -0400 Subject: [PATCH] Fix no swact for failure of critical services This fix is to ensure keeping service failure counting over successful audit. When service enabled audit successfully completes, SM reset the service failure state. However it should not reset the service fail-count. The fail-count should only be reset after the grace period. Closes-Bug: 1893669 Change-Id: I6996fe3f1c08c38da6f26243aee2b95b083069f0 Signed-off-by: Bin Qian --- service-mgmt/sm/src/sm_service_table.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/service-mgmt/sm/src/sm_service_table.c b/service-mgmt/sm/src/sm_service_table.c index 674e1eea..9801abcd 100644 --- a/service-mgmt/sm/src/sm_service_table.c +++ b/service-mgmt/sm/src/sm_service_table.c @@ -40,7 +40,6 @@ bool sm_service_clear_failure_state(SmServiceT* service) bool prev_failure_condition; prev_failure_condition = service->recover || - service->fail_count > 0 || service->action_fail_count > 0 || service->transition_fail_count > 0 || service->status == SM_SERVICE_STATUS_FAILED || @@ -50,7 +49,6 @@ bool sm_service_clear_failure_state(SmServiceT* service) if( prev_failure_condition ) { service->recover = false; - service->fail_count = 0; service->action_fail_count = 0; service->transition_fail_count = 0; service->status = SM_SERVICE_STATUS_NONE;