da53f143ee
below issures are removed from ignore cases:
E114 indentation is not a multiple of four (comment)
E116 unexpected indentation (comment)
E121 continuation line under-indented for hanging indent
E122 continuation line missing indentation or outdented
E123 closing bracket does not match indentation of opening bracket's line
E124 closing bracket does not match visual indentation
E125 continuation line with same indent as next logical line
E126 continuation line over-indented for hanging indent
E127 continuation line over-indented for visual indent
E128 continuation line under-indented for visual indent
E129 visually indented line with same indent as next logical line
E131 continuation line unaligned for hanging indent
E201 whitespace after '('
E228 missing whitespace around modulo operator
E231 missing whitespace after ','
E241 multiple spaces after ':'
E251 unexpected spaces around keyword / parameter equals
E265 block comment should start with '#'
E271 multiple spaces after keyword
E302 expected 2 blank lines, found 1
E303 too many blank lines
E305 expected 2 blank lines after class or function definition, found 1
E704 multiple statements on one line (def)
E713 test for membership should be 'not in'
E714 test for object identity should be 'is not'
E722 do not use bare except'
E731 do not assign a lambda expression, use a def
E999 SyntaxError: invalid syntax (this is likely python3)
F401 <foo> imported but unused
F841 local variable 'foo' is assigned to but never used
H201: no 'except:'
H233: Python 3.x incompatible use of print operator
B001 Do not use bare `except:`
B004 Using `hasattr(x, '__call__')` to test
if `x` is callable is unreliable.
B305 `.next()` is not a thing on Python 3. Use the `next()` builtin.
B306 `BaseException.message` has been deprecated as of Python 2.6
and is removed in Python 3.
B007 Loop control variable 'key' not used within the loop body.
remain below issues in ignores:
E402 module level import not at top of file
./service-mgmt-api/sm-api/sm_api/cmd/__init__.py:25
Hxxx since which are related with document format
F811 redefinition of unused '<foo>' from line <x>
./service-mgmt-tools/sm-tools/sm_tools/sm_configure.py:18
F821 undefined name 'e'
./service-mgmt-api/sm-api/sm_api/common/utils.py:448
B006 Do not use mutable data structures for argument defaults.
./service-mgmt-api/sm-api/sm_api/common/service.py:59
B008 Do not perform calls in argument defaults.
./service-mgmt-api/sm-api/sm_api/openstack/common/timeutils.py:117
Test have been done:Build,Deploy,some smc command,such as smc service-list,
smc service-show, sm-dump, etc
Story: 2003430
Task: 26524
Change-Id: I3e2a4a31f87e3ff66cfce86f54285e830ee1c3dc
Signed-off-by: Sun Austin <austin.sun@intel.com>
111 lines
3.7 KiB
Python
111 lines
3.7 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright (c) 2013 Rackspace Hosting
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
# Copyright (c) 2013-2014 Wind River Systems, Inc.
|
|
#
|
|
|
|
|
|
"""Multiple DB API backend support.
|
|
|
|
Supported configuration options:
|
|
|
|
The following two parameters are in the 'database' group:
|
|
`backend`: DB backend name or full module path to DB backend module.
|
|
`use_tpool`: Enable thread pooling of DB API calls.
|
|
|
|
A DB backend module should implement a method named 'get_backend' which
|
|
takes no arguments. The method can return any object that implements DB
|
|
API methods.
|
|
|
|
*NOTE*: There are bugs in eventlet when using tpool combined with
|
|
threading locks. The python logging module happens to use such locks. To
|
|
work around this issue, be sure to specify thread=False with
|
|
eventlet.monkey_patch().
|
|
|
|
A bug for eventlet has been filed here:
|
|
|
|
https://bitbucket.org/eventlet/eventlet/issue/137/
|
|
"""
|
|
import functools
|
|
|
|
from oslo_config import cfg
|
|
|
|
from sm_api.openstack.common import importutils
|
|
from sm_api.openstack.common import lockutils
|
|
|
|
|
|
db_opts = [
|
|
cfg.StrOpt('backend',
|
|
default='sqlalchemy',
|
|
deprecated_name='db_backend',
|
|
deprecated_group='DEFAULT',
|
|
help='The backend to use for db'),
|
|
cfg.BoolOpt('use_tpool',
|
|
default=False,
|
|
deprecated_name='dbapi_use_tpool',
|
|
deprecated_group='DEFAULT',
|
|
help='Enable the experimental use of thread pooling for '
|
|
'all DB API calls')
|
|
]
|
|
|
|
CONF = cfg.CONF
|
|
CONF.register_opts(db_opts, 'database')
|
|
|
|
|
|
class DBAPI(object):
|
|
def __init__(self, backend_mapping=None):
|
|
if backend_mapping is None:
|
|
backend_mapping = {}
|
|
self.__backend = None
|
|
self.__backend_mapping = backend_mapping
|
|
|
|
@lockutils.synchronized('dbapi_backend', 'sm_api-')
|
|
def __get_backend(self):
|
|
"""Get the actual backend. May be a module or an instance of
|
|
a class. Doesn't matter to us. We do this synchronized as it's
|
|
possible multiple greenthreads started very quickly trying to do
|
|
DB calls and eventlet can switch threads before self.__backend gets
|
|
assigned.
|
|
"""
|
|
if self.__backend:
|
|
# Another thread assigned it
|
|
return self.__backend
|
|
backend_name = CONF.database.backend
|
|
self.__use_tpool = CONF.database.use_tpool
|
|
if self.__use_tpool:
|
|
from eventlet import tpool
|
|
self.__tpool = tpool
|
|
# Import the untranslated name if we don't have a
|
|
# mapping.
|
|
backend_path = self.__backend_mapping.get(backend_name,
|
|
backend_name)
|
|
backend_mod = importutils.import_module(backend_path)
|
|
self.__backend = backend_mod.get_backend()
|
|
return self.__backend
|
|
|
|
def __getattr__(self, key):
|
|
backend = self.__backend or self.__get_backend()
|
|
attr = getattr(backend, key)
|
|
if not self.__use_tpool or not callable(attr):
|
|
return attr
|
|
|
|
def tpool_wrapper(*args, **kwargs):
|
|
return self.__tpool.execute(attr, *args, **kwargs)
|
|
|
|
functools.update_wrapper(tpool_wrapper, attr)
|
|
return tpool_wrapper
|