ha/a63ea17c1b4ad07488b14384ce8f761032a913fe

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "f1e7e2f1_c5a5950a",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 8
      },
      "lineNbr": 0,
      "author": {
        "id": 28466
      },
      "writtenOn": "2024-02-23T15:34:26Z",
      "side": 1,
      "message": "as discussed, the potential patching issues will be handled in separated user story.",
      "revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "db6d1189_62f82b4b",
        "filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
        "patchSetId": 8
      },
      "lineNbr": 461,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-02-26T17:11:29Z",
      "side": 1,
      "message": "Does importing python modules declared in a function meet our coding standard ? I thought we were required to put all imports at the top of the file in alphabetical order.",
      "range": {
        "startLine": 459,
        "startChar": 8,
        "endLine": 461,
        "endChar": 61
      },
      "revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "5a0fdb47_3e72039b",
        "filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
        "patchSetId": 8
      },
      "lineNbr": 461,
      "author": {
        "id": 34895
      },
      "writtenOn": "2024-02-26T19:04:30Z",
      "side": 1,
      "message": "I think the general coding standard don\u0027t apply in here as we don\u0027t we don\u0027t want to import them if it is not for platform upgrade case.",
      "parentUuid": "db6d1189_62f82b4b",
      "range": {
        "startLine": 459,
        "startChar": 8,
        "endLine": 461,
        "endChar": 61
      },
      "revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f4feb399_0031a0df",
        "filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
        "patchSetId": 8
      },
      "lineNbr": 461,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-02-26T21:22:47Z",
      "side": 1,
      "message": "wouldn\u0027t this be invoked on \u0027system host-swact\u0027 as well, not only upgrades ?",
      "parentUuid": "5a0fdb47_3e72039b",
      "range": {
        "startLine": 459,
        "startChar": 8,
        "endLine": 461,
        "endChar": 61
      },
      "revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ae74cde8_40fb0644",
        "filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
        "patchSetId": 8
      },
      "lineNbr": 461,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-02-26T21:26:01Z",
      "side": 1,
      "message": "I disagree as you won\u0027t know of the import error until you are in the function ; in upgrading or as John suggests possibly in Swact too.",
      "parentUuid": "5a0fdb47_3e72039b",
      "range": {
        "startLine": 459,
        "startChar": 8,
        "endLine": 461,
        "endChar": 61
      },
      "revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1874fa6d_d35acdf1",
        "filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
        "patchSetId": 8
      },
      "lineNbr": 461,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-02-26T22:03:49Z",
      "side": 1,
      "message": "John suggested the following which makes sense\n\n\"the guideline should be if the imports rarely used then it can be within a method; otherwise should be at top of file … since there\u0027s a slight cost to the import\"\n\nIf this code is only run on upgrades then I withdraw my complaint.",
      "parentUuid": "ae74cde8_40fb0644",
      "range": {
        "startLine": 459,
        "startChar": 8,
        "endLine": 461,
        "endChar": 61
      },
      "revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}