Update patch set 2

Patch Set 2: (6 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 35278 \u003c35278@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35298\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 35298 \u003c35298@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35298\u003e replied on the change"}
2023-10-10 11:21:45 +00:00
parent cc42c29431
commit 2348450966
1 changed files with 142 additions and 0 deletions
--- a/142
+++ b/142
@@ -0,0 +1,142 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "a26476f7_4de59469",
+        "filename": "filesystem/luks/src/encryption/luks-fs-mgr.cpp",
+        "patchSetId": 2
+      },
+      "lineNbr": 511,
+      "author": {
+        "id": 35298
+      },
+      "writtenOn": "2023-10-10T11:21:45Z",
+      "side": 1,
+      "message": "No checking for the failure of fprintf. We should log and return false.",
+      "range": {
+        "startLine": 511,
+        "startChar": 3,
+        "endLine": 511,
+        "endChar": 35
+      },
+      "revId": "af2168d74251154f11fdb3cd1d96bbb825d867b8",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "dd21400f_3abde294",
+        "filename": "filesystem/luks/src/encryption/luks-fs-mgr.cpp",
+        "patchSetId": 2
+      },
+      "lineNbr": 523,
+      "author": {
+        "id": 35298
+      },
+      "writtenOn": "2023-10-10T11:21:45Z",
+      "side": 1,
+      "message": "nit: empty space at the end of the line.",
+      "range": {
+        "startLine": 523,
+        "startChar": 2,
+        "endLine": 523,
+        "endChar": 3
+      },
+      "revId": "af2168d74251154f11fdb3cd1d96bbb825d867b8",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "47d39fa9_882cec4f",
+        "filename": "filesystem/luks/src/encryption/luks-fs-mgr.cpp",
+        "patchSetId": 2
+      },
+      "lineNbr": 758,
+      "author": {
+        "id": 35298
+      },
+      "writtenOn": "2023-10-10T11:21:45Z",
+      "side": 1,
+      "message": "Should use \u0027getPassPhraseType\u0027 function.",
+      "range": {
+        "startLine": 758,
+        "startChar": 3,
+        "endLine": 758,
+        "endChar": 58
+      },
+      "revId": "af2168d74251154f11fdb3cd1d96bbb825d867b8",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "5ee2ef71_11544b6c",
+        "filename": "filesystem/luks/src/encryption/luks-fs-mgr.cpp",
+        "patchSetId": 2
+      },
+      "lineNbr": 828,
+      "author": {
+        "id": 35298
+      },
+      "writtenOn": "2023-10-10T11:21:45Z",
+      "side": 1,
+      "message": "Don\u0027t see a need for a function call just for logging. Lets compare in the \u0027if\u0027 and anyways we have if and else block for logging.",
+      "range": {
+        "startLine": 828,
+        "startChar": 12,
+        "endLine": 828,
+        "endChar": 53
+      },
+      "revId": "af2168d74251154f11fdb3cd1d96bbb825d867b8",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "02b221ba_99c47366",
+        "filename": "filesystem/luks/src/encryption/luks-fs-mgr.cpp",
+        "patchSetId": 2
+      },
+      "lineNbr": 1070,
+      "author": {
+        "id": 35298
+      },
+      "writtenOn": "2023-10-10T11:21:45Z",
+      "side": 1,
+      "message": "The same/similar code is used earlier to validate the size. Lets create a function and call it from both the places.",
+      "range": {
+        "startLine": 1064,
+        "startChar": 0,
+        "endLine": 1070,
+        "endChar": 9
+      },
+      "revId": "af2168d74251154f11fdb3cd1d96bbb825d867b8",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "5411a958_42c8f13f",
+        "filename": "filesystem/luks/src/encryption/luks-fs-mgr.cpp",
+        "patchSetId": 2
+      },
+      "lineNbr": 1095,
+      "author": {
+        "id": 35298
+      },
+      "writtenOn": "2023-10-10T11:21:45Z",
+      "side": 1,
+      "message": "Suggestion: cleanupObjects are called multipletimes. As the objective is to do it before returning. May be a cleanup block and goto is useful.",
+      "range": {
+        "startLine": 1093,
+        "startChar": 0,
+        "endLine": 1095,
+        "endChar": 21
+      },
+      "revId": "af2168d74251154f11fdb3cd1d96bbb825d867b8",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}