{ "comments": [ { "unresolved": true, "key": { "uuid": "3302aee0_d792dcef", "filename": "/COMMIT_MSG", "patchSetId": 3 }, "lineNbr": 9, "author": { "id": 31683 }, "writtenOn": "2024-05-01T17:52:16Z", "side": 1, "message": "I think you mean StarlingX", "range": { "startLine": 9, "startChar": 9, "endLine": 9, "endChar": 14 }, "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "348f2dc5_1badabe1", "filename": "/COMMIT_MSG", "patchSetId": 3 }, "lineNbr": 9, "author": { "id": 31683 }, "writtenOn": "2024-05-01T17:52:16Z", "side": 1, "message": "It hasn\u0027t yet. There\u0027s a separate branch for bookworm, f/bookworm . Are you sure this commit belongs in the master branch?", "range": { "startLine": 9, "startChar": 27, "endLine": 9, "endChar": 58 }, "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "6040bb5b_9c100d96", "filename": "/COMMIT_MSG", "patchSetId": 3 }, "lineNbr": 9, "author": { "id": 28464 }, "writtenOn": "2024-05-01T18:18:04Z", "side": 1, "message": "Yes, this update is planned for the master branch in prep for the bookworm release. This version will work in both releases. I have corrected the wording.", "parentUuid": "348f2dc5_1badabe1", "range": { "startLine": 9, "startChar": 27, "endLine": 9, "endChar": 58 }, "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "a38c89bb_be5b4015", "filename": "/COMMIT_MSG", "patchSetId": 3 }, "lineNbr": 9, "author": { "id": 28464 }, "writtenOn": "2024-05-01T18:18:04Z", "side": 1, "message": "Done", "parentUuid": "3302aee0_d792dcef", "range": { "startLine": 9, "startChar": 9, "endLine": 9, "endChar": 14 }, "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "e51e635b_5f72aa17", "filename": "/PATCHSET_LEVEL", "patchSetId": 3 }, "lineNbr": 0, "author": { "id": 28464 }, "writtenOn": "2024-05-01T17:47:53Z", "side": 1, "message": "recheck", "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "0df649f9_4921c05e", "filename": "/PATCHSET_LEVEL", "patchSetId": 3 }, "lineNbr": 0, "author": { "id": 31683 }, "writtenOn": "2024-05-01T17:52:16Z", "side": 1, "message": "Shouldn\u0027t we download the original taball as part of the build? Ie don\u0027t maintain a copy of the entire source code, just a tarball URL + patches maintained here. I\u0027m sure there examples of similar cases elsewhere in StarlingX.", "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "425cddd7_84dcc668", "filename": "/PATCHSET_LEVEL", "patchSetId": 3 }, "lineNbr": 0, "author": { "id": 28464 }, "writtenOn": "2024-05-01T20:55:17Z", "side": 1, "message": "There are no patches yet. \nWill the build system be able to \u0027create a Debian package\u0027 from a zip file ? That\u0027s all that is available. \n\nhttps://github.com/DMTF/Redfishtool/tree/1.1.8\n\nIf you could give me a specific example of where that is done already in our build system I\u0027ll take a look.", "parentUuid": "0df649f9_4921c05e", "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "b57cb440_b0cbb796", "filename": "/PATCHSET_LEVEL", "patchSetId": 3 }, "lineNbr": 0, "author": { "id": 31683 }, "writtenOn": "2024-05-01T21:23:04Z", "side": 1, "message": "I think this: https://opendev.org/starlingx/integ/src/branch/master/ldap/openldap/debian", "parentUuid": "425cddd7_84dcc668", "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "6cc936df_f99b1e15", "filename": "/PATCHSET_LEVEL", "patchSetId": 3 }, "lineNbr": 0, "author": { "id": 28464 }, "writtenOn": "2024-05-02T16:25:03Z", "side": 1, "message": "I\u0027m able to modify the meta_data.yaml to download the zip file. \n\n---\ndebname: redfishtool\ndebver: 1.1.8\ndl_path:\n name: Redfishtool-1.1.8.zip\n url: https://github.com/DMTF/Redfishtool/archive/1.1.8/Redfishtool-1.1.8.zip\n md5sum: 5694fc312b2f306a5d2407d449a1676b\n sha256sum: 2377e5fab811bfb8702122bb29916329736c685e7e2557df1da53d917a11e959\nrevision:\n dist: $STX_DIST\n PKG_GITREVCOUNT: true\n\n\nHowever, trying to \u0027build-pkgs -c -p redfishtool\u0027 leads to an unsupported file type error.\n\n2024-05-02 16:19:19,036 - debrepack - ERROR: Not supported tarball type, the supported types are: tar.gz|tar.bz2|tar.xz|tgz\n2024-05-02 16:19:19,037 - debcontroller - ERROR: Redfishtool-1.1.8.zip type is not supported\n2024-05-02 16:19:19,037 - debcontroller - ERROR: Failed to create needed dsc file, exit", "parentUuid": "b57cb440_b0cbb796", "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "2d23e170_03b27b4d", "filename": "/PATCHSET_LEVEL", "patchSetId": 3 }, "lineNbr": 0, "author": { "id": 28464 }, "writtenOn": "2024-05-06T19:43:10Z", "side": 1, "message": "I\u0027ve implemented the changes that fetch the redfishtool from github during the downloader stage and builds that package along with a single github patch ion the build stage.", "parentUuid": "6cc936df_f99b1e15", "revId": "6a893174e0299ed06945572f0e93ad5a464e3aff", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] }