06c396fbe3
The issue reported is a particular case of a BC configured with redundant PTP clocks with same priority. When a clock recovers from a failure, as both clock were configured with same priority it's expected the active clock source to remain active. But if the recovered clock presented a better local clock class than active, it was being selected active. This specific case was fixed. Closes-bug: 2084723 Test plan: BC with same priority PASS: Start the PTP service with all clocks out of requirements, one is selected, no matter which one. PASS: Then, when the backup clock recovers from failure it is selected active. PASS: Then, when the other clock recovers from failure it remains as backup, no matter the local clock class. PASS: Then, when the active goes out of requirement, the backup is set active. Test plan: GM with same priority PASS: Start the PTP service with all clocks out of requirements, one is selected, no matter which one. PASS: Then, when the backup clock recovers from failure it is selected active. PASS: Then, when the other clock recovers from failure it remains as backup, no matter the local clock class. PASS: Then, when the active goes out of requirement, the backup is set active. Change-Id: Id2568bc8bbaad4cbf15070314f7904d3c3bbd53d Signed-off-by: Andre Mauricio Zelak <andre.zelak@windriver.com>
34 lines
1.2 KiB
Diff
34 lines
1.2 KiB
Diff
From: Andre Mauricio Zelak <andre.zelak@windriver.com>
|
|
Date: Mon, 12 Jun 2023 17:51:10 -0300
|
|
Subject: [PATCH 32/61] phc2sys: Fix regression in the automatic mode.
|
|
|
|
Commit ac7d69bbc476 ("pmc_agent: Convert the method that queries the
|
|
port properties.") had the well meant intention of the cleaning up the
|
|
error code semantics of the port properties query function. However,
|
|
that commit mixed up the normal, external semantics of zero meaning
|
|
success with the internal semantics where zero is an error. Correct
|
|
the issue by replacing the hard coded number with the proper macro.
|
|
|
|
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
|
|
Fixes: ac7d69bbc476 ("pmc_agent: Convert the method that queries the port properties.")
|
|
|
|
[commit 0fb1be2f5c4d6905f33a2b1c31e7496d52296748 upstream]
|
|
Signed-off-by: Andre Mauricio Zelak <andre.zelak@windriver.com>
|
|
---
|
|
pmc_agent.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/pmc_agent.c b/pmc_agent.c
|
|
index 6e6627d..623f300 100644
|
|
--- a/pmc_agent.c
|
|
+++ b/pmc_agent.c
|
|
@@ -338,7 +338,7 @@ int pmc_agent_query_port_properties(struct pmc_agent *node, int timeout,
|
|
iface[len] = '\0';
|
|
|
|
msg_put(msg);
|
|
- res = 0;
|
|
+ res = RUN_PMC_OKAY;
|
|
break;
|
|
}
|
|
out:
|