600ad549b5
A new time traceable flag was added to pmc agent to store the current time traceable status. This flag replaces the utc_offset_traceable flag in the HA clock selection algorithm and status command. Test plan: HA clock selection algorithm PASS: Verify the clock source which time isn't traceable is discarded by the algorithm if ha_gm_timeTraceable is enabled. PASS: Verify the clock source which time is traceable isn't discarded by the algorithm if ha_gm_timeTraceable is enabled. Regression: status command PASS: Verify the response of status command shows the correct GM time traceable. The 'valid sources' command is used to get a list of interfaces which the clock is matching the requirements. The response contains a space separated list of interfaces, or "None" when not a single clock is matching all the requirements. Test plan: valid sources command PASS: Verify that a space separated list of interface is returned when one or more clocks match the requirements. PASS: Verify that the string "None" is returned when not a single clock match the requirements. Now the GM time traceable check is enabled by default as it is an important check for both T-GM and T-BC scenarios. The GM time traceable check is controlled in configuration by using the ha_gm_timeTraceable setting, and it can be disabled using the value 0 (ha_gm_timeTraceable 0). Test plan: default value PASS Verify the check is performed by default. PASS Verify the user can disable the check by configuration. Bonus: Fixed the behavior when none clock is matching the requirements and the active clock source is disabled using the 'disable source <interface>' command. The interface is must be disabled and a new clock source is selected. Test plan: none clock is matching the requirements PASS: Verify that the active source can be disabled and a new one is selected. PASS: Verify that an attempt to disable the last active interface fails and an appopriated message is given as response. PASS: Verify that the interface with higher priority is selected after re-enabling it. PASS: Verify the active clock source doesn't change if another interface is disabled. PASS: Verify the active clock source doesn't change if another interface is re-enabled. Story: 2010723 Task: 48702 Change-Id: I64193575a995e520d36460c0ebb8dd452fa8c2b8 Signed-off-by: Andre Mauricio Zelak <andre.zelak@windriver.com>
85 lines
2.7 KiB
Diff
85 lines
2.7 KiB
Diff
From e4fd6a930213e6f0f009eb070d51b1e14db60d1b Mon Sep 17 00:00:00 2001
|
|
From: Miroslav Lichvar <mlichvar@redhat.com>
|
|
Date: Wed, 18 May 2022 11:33:38 +0200
|
|
Subject: [PATCH 10/54] phc2sys: Don't exit when reading of PHC fails with EBUSY.
|
|
|
|
Reading of the PHC can occasionally fail with some drivers, e.g. the ice
|
|
driver returns EBUSY when it fails to get a lock. Continue in the loop
|
|
instead of exiting on the error.
|
|
|
|
Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>
|
|
|
|
[ commit e8dc364f9fd5fbdac5d2c5e433f28e9da0028d49 upstream
|
|
We drop two hunks of it, namely the stuff that applies to
|
|
clockadj_compare, because they apply to the source code
|
|
ahead of baseline currently used by StarlingX ]
|
|
|
|
Signed-off-by: Douglas Henrique Koerich <douglashenrique.koerich@windriver.com>
|
|
Signed-off-by: Andre Mauricio Zelak <andre.zelak@windriver.com>
|
|
---
|
|
phc2sys.c | 31 +++++++++++++++++++------------
|
|
1 file changed, 19 insertions(+), 12 deletions(-)
|
|
|
|
diff --git a/phc2sys.c b/phc2sys.c
|
|
index 44d6872..7959015 100644
|
|
--- a/phc2sys.c
|
|
+++ b/phc2sys.c
|
|
@@ -722,6 +722,7 @@ static int do_loop(struct phc2sys_private *priv, int subscriptions)
|
|
struct clock *clock;
|
|
uint64_t ts;
|
|
int64_t offset, delay;
|
|
+ int err;
|
|
|
|
interval.tv_sec = priv->phc_interval;
|
|
interval.tv_nsec = (priv->phc_interval - interval.tv_sec) * 1e9;
|
|
@@ -765,28 +766,34 @@ static int do_loop(struct phc2sys_private *priv, int subscriptions)
|
|
if (clock->clkid == CLOCK_REALTIME &&
|
|
priv->master->sysoff_method >= 0) {
|
|
/* use sysoff */
|
|
- if (sysoff_measure(CLOCKID_TO_FD(priv->master->clkid),
|
|
- priv->master->sysoff_method,
|
|
- priv->phc_readings,
|
|
- &offset, &ts, &delay) < 0)
|
|
- return -1;
|
|
+ err = sysoff_measure(CLOCKID_TO_FD(priv->master->clkid),
|
|
+ priv->master->sysoff_method,
|
|
+ priv->phc_readings,
|
|
+ &offset, &ts, &delay);
|
|
} else if (priv->master->clkid == CLOCK_REALTIME &&
|
|
clock->sysoff_method >= 0) {
|
|
/* use reversed sysoff */
|
|
- if (sysoff_measure(CLOCKID_TO_FD(clock->clkid),
|
|
- clock->sysoff_method,
|
|
- priv->phc_readings,
|
|
- &offset, &ts, &delay) < 0)
|
|
- return -1;
|
|
- offset = -offset;
|
|
- ts += offset;
|
|
+ err = sysoff_measure(CLOCKID_TO_FD(clock->clkid),
|
|
+ clock->sysoff_method,
|
|
+ priv->phc_readings,
|
|
+ &offset, &ts, &delay);
|
|
+ if (!err) {
|
|
+ offset = -offset;
|
|
+ ts += offset;
|
|
+ }
|
|
} else {
|
|
+ err = 0;
|
|
/* use phc */
|
|
if (!read_phc(priv->master->clkid, clock->clkid,
|
|
priv->phc_readings,
|
|
&offset, &ts, &delay))
|
|
continue;
|
|
}
|
|
+ if (err == -EBUSY)
|
|
+ continue;
|
|
+ if (err)
|
|
+ return -1;
|
|
+
|
|
update_clock(priv, clock, offset, ts, delay);
|
|
}
|
|
}
|
|
--
|
|
2.29.2
|
|
|