600ad549b5
A new time traceable flag was added to pmc agent to store the current time traceable status. This flag replaces the utc_offset_traceable flag in the HA clock selection algorithm and status command. Test plan: HA clock selection algorithm PASS: Verify the clock source which time isn't traceable is discarded by the algorithm if ha_gm_timeTraceable is enabled. PASS: Verify the clock source which time is traceable isn't discarded by the algorithm if ha_gm_timeTraceable is enabled. Regression: status command PASS: Verify the response of status command shows the correct GM time traceable. The 'valid sources' command is used to get a list of interfaces which the clock is matching the requirements. The response contains a space separated list of interfaces, or "None" when not a single clock is matching all the requirements. Test plan: valid sources command PASS: Verify that a space separated list of interface is returned when one or more clocks match the requirements. PASS: Verify that the string "None" is returned when not a single clock match the requirements. Now the GM time traceable check is enabled by default as it is an important check for both T-GM and T-BC scenarios. The GM time traceable check is controlled in configuration by using the ha_gm_timeTraceable setting, and it can be disabled using the value 0 (ha_gm_timeTraceable 0). Test plan: default value PASS Verify the check is performed by default. PASS Verify the user can disable the check by configuration. Bonus: Fixed the behavior when none clock is matching the requirements and the active clock source is disabled using the 'disable source <interface>' command. The interface is must be disabled and a new clock source is selected. Test plan: none clock is matching the requirements PASS: Verify that the active source can be disabled and a new one is selected. PASS: Verify that an attempt to disable the last active interface fails and an appopriated message is given as response. PASS: Verify that the interface with higher priority is selected after re-enabling it. PASS: Verify the active clock source doesn't change if another interface is disabled. PASS: Verify the active clock source doesn't change if another interface is re-enabled. Story: 2010723 Task: 48702 Change-Id: I64193575a995e520d36460c0ebb8dd452fa8c2b8 Signed-off-by: Andre Mauricio Zelak <andre.zelak@windriver.com>
60 lines
1.8 KiB
Diff
60 lines
1.8 KiB
Diff
From e74d268ac5432c0e41dc14fb0ea648a432d8e340 Mon Sep 17 00:00:00 2001
|
|
From: Andre Mauricio Zelak <andre.zelak@windriver.com>
|
|
Date: Thu, 31 Aug 2023 16:05:15 -0300
|
|
Subject: [PATCH 53/54] Disable active interface failing
|
|
|
|
Fixed the behavior when none clock is matching the requirements and the
|
|
active clock source is disabled using the 'disable source <interface>'
|
|
command. The interface is must be disabled and a new clock source is
|
|
selected.
|
|
|
|
Test plan: none clock is matching the requirements
|
|
PASS: Verify that the active source can be disabled and a new one is
|
|
selected.
|
|
PASS: Verify that an attempt to disable the last active interface
|
|
fails and an appopriated message is given as response.
|
|
PASS: Verify that the interface with higher priority is selected after
|
|
re-enabling it.
|
|
PASS: Verify the active clock source doesn't change if another
|
|
interface is disabled.
|
|
PASS: Verify the active clock source doesn't change if another
|
|
interface is re-enabled.
|
|
|
|
Story: 2010723
|
|
Task: 48702
|
|
|
|
Signed-off-by: Andre Mauricio Zelak <andre.zelak@windriver.com>
|
|
---
|
|
phc2sys.c | 8 ++++++++
|
|
1 file changed, 8 insertions(+)
|
|
|
|
diff --git a/phc2sys.c b/phc2sys.c
|
|
index 9893675..4120568 100644
|
|
--- a/phc2sys.c
|
|
+++ b/phc2sys.c
|
|
@@ -1115,6 +1115,10 @@ static struct clock* ha_select_clock(struct phc2sys_private *priv, struct config
|
|
if (clock->node == NULL)
|
|
continue;
|
|
|
|
+ /* clock disabled */
|
|
+ if (!clock->enabled)
|
|
+ continue;
|
|
+
|
|
/* get clock class */
|
|
clock_class = clock->node->dds.clockQuality.clockClass;
|
|
if (clock_class <= lowest_clock_class) {
|
|
@@ -1137,6 +1141,10 @@ static struct clock* ha_select_clock(struct phc2sys_private *priv, struct config
|
|
if (clock->node == NULL)
|
|
continue;
|
|
|
|
+ /* clock disabled */
|
|
+ if (!clock->enabled)
|
|
+ continue;
|
|
+
|
|
best = clock;
|
|
}
|
|
}
|
|
--
|
|
2.25.1
|
|
|