Update patch set 1

Browse Source

Patch Set 1:

> > > > (1 comment)
 > > >
 > > > What I have there now gives me 1 as the pkg version.  But if I
 > > > understand what you're saying I should cd to kernel-std and do
 > a
 > > > git log . and grab that commit id.  Do the same for kernel-rt. 
 > I
 > > > already did that.  Then what do I do for PKG_BASE_SRCREV?
 > >
 > > Yes, the values for the kernel dirs seem fine. The PKG_BASE dir
 > in
 > > this case would be kernel-modules/mlnx-ofa_kernel ... so you'd do
 > > the same there, getting the most recent SHA in that dir
 > 
 > Doing that now gives the initial pkg ver as 2.  Should I bother
 > trying to fudge it down to 1 or just not sweat it given that merge
 > commits could make it go up by 2 anyway?  ie. the actual number
 > doesn't matter much as long as it goes up when it should?

I think that's because you did not account for the .gitreview commit in the 4.0 branch, since this is a cherry pick, then the result will be 2, that fine with me, there is also the SR-IOV commit which will come before or after this.

Patch-set: 1
Label: Code-Review=0

...

This commit is contained in:

Gerrit User 28607

2020-07-22 15:47:25 +00:00

committed by Gerrit Code Review

parent 46f99377ad

commit 69678cd122

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available