From 344dba1a62af248a8164c174a6f9d00065dd23f1 Mon Sep 17 00:00:00 2001
From: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Mon, 1 Apr 2024 15:22:38 +0000
Subject: [PATCH] Update patch set 2

Patch Set 2:

(3 comments)

Patch-set: 2
CC: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 35022 \u003c35022@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
---
 c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32 | 73 ++++++++++++++++++++++++
 1 file changed, 73 insertions(+)
 create mode 100644 c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32

diff --git a/c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32 b/c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32
new file mode 100644
index 00000000..8fb899e7
--- /dev/null
+++ b/c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32
@@ -0,0 +1,73 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "c4f7548f_f76770b0",
+        "filename": "kickstart/files/kickstart.cfg",
+        "patchSetId": 2
+      },
+      "lineNbr": 2722,
+      "author": {
+        "id": 28464
+      },
+      "writtenOn": "2024-04-01T15:22:38Z",
+      "side": 1,
+      "message": "1 to 3 digits",
+      "range": {
+        "startLine": 2722,
+        "startChar": 29,
+        "endLine": 2722,
+        "endChar": 37
+      },
+      "revId": "c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b155bde9_7e6ef612",
+        "filename": "kickstart/files/kickstart.cfg",
+        "patchSetId": 2
+      },
+      "lineNbr": 2722,
+      "author": {
+        "id": 28464
+      },
+      "writtenOn": "2024-04-01T15:22:38Z",
+      "side": 1,
+      "message": "repeated 3 times and then [0-9]{1,3} matches the final group of 1 to 3 digits.",
+      "range": {
+        "startLine": 2722,
+        "startChar": 66,
+        "endLine": 2722,
+        "endChar": 68
+      },
+      "revId": "c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "43db5997_58078c33",
+        "filename": "kickstart/files/kickstart.cfg",
+        "patchSetId": 2
+      },
+      "lineNbr": 2723,
+      "author": {
+        "id": 28464
+      },
+      "writtenOn": "2024-04-01T15:22:38Z",
+      "side": 1,
+      "message": "Missing ${}.\n\nHowever, more critically, using the mgmt_ip rather than the dig prevents this change from ever being patched back.\n\nThe addition of the mgmt_ip was implemented for an IPSec feature for which there is no plan or intent to patch back.\n\nYou can use the following command and filter out domain names and revert back to the original code where it\u0027s assumed to be IPV6 if the ipv6_addr variable is not empty.\n\nHere is the output in the diff systems\n\nIPV6:\n[sysadmin@controller-1 ~(keystone_admin)]$ dig +short AAAA controller\ncontroller.internal.\nfdff:719a:bf60:2080::2\n\nIPV4:\nsysadmin@controller-0:~$ dig +short AAAA controller\ncontroller.internal.\n\nI think doing so would be a more portable implementation and line up with the way this has always been done before FQDN feature addition.",
+      "range": {
+        "startLine": 2723,
+        "startChar": 11,
+        "endLine": 2723,
+        "endChar": 19
+      },
+      "revId": "c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}
\ No newline at end of file