starlingx
/
metal
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 34119 <34119@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 32870 \u003c32870@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34119\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34119 \u003c34119@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34119\u003e replied on the change"}
This commit is contained in:
Gerrit User 34119 2022-10-06 16:35:28 +00:00 committed by Gerrit Code Review
parent 099ad520d4
commit c760188485
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
00c9a4dba0e364ea8cdeefc8a4a57b367ed79232 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "aa051416_6dd8bee9",
"filename": "kickstart/files/kickstart.cfg",
"patchSetId": 3
},
"lineNbr": 1505,
"author": {
"id": 34119
},
"writtenOn": "2022-10-06T16:35:28Z",
"side": 1,
"message": "Please use the single bracket test for consistency with the rest of the code.\nie. if [ \"${WIPE....}... ]; then",
"revId": "00c9a4dba0e364ea8cdeefc8a4a57b367ed79232",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
4b070f317edb152de276f464ab50a329d1855547 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "f081801a_5dc9f22e",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 22,
"author": {
"id": 34119
},
"writtenOn": "2022-10-06T16:35:28Z",
"side": 1,
"message": "Please provide the test plan and results...",
"revId": "4b070f317edb152de276f464ab50a329d1855547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}