metal/a44610b90605ad3bacd8c36141098c43c59ee087

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "5449bdca_e94d00ca",
        "filename": "mtce-common/src/common/nodeBase.h",
        "patchSetId": 7
      },
      "lineNbr": 1221,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-03-26T13:26:17Z",
      "side": 1,
      "message": "in case of future upgrades, do these messages need to be versioned? or is versioning related to mtc_cmd.ver ?",
      "revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "76425a5d_8c534397",
        "filename": "mtce-common/src/common/nodeBase.h",
        "patchSetId": 7
      },
      "lineNbr": 1221,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-03-28T12:16:38Z",
      "side": 1,
      "message": "These are not messages. There are internal pxeboot_mtcalive_monitor FSM states.",
      "parentUuid": "5449bdca_e94d00ca",
      "revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1b464e22_aa998eef",
        "filename": "mtce-common/src/common/nodeUtil.cpp",
        "patchSetId": 7
      },
      "lineNbr": 1915,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-03-26T13:26:17Z",
      "side": 1,
      "message": "is the else of this an error condition?",
      "range": {
        "startLine": 1915,
        "startChar": 5,
        "endLine": 1915,
        "endChar": 9
      },
      "revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "fb535e02_d4964feb",
        "filename": "mtce-common/src/common/nodeUtil.cpp",
        "patchSetId": 7
      },
      "lineNbr": 1915,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-03-28T12:16:38Z",
      "side": 1,
      "message": "Not really since the returned pxeboot_address will not be updated and the caller will see that. I will add a warning log.",
      "parentUuid": "1b464e22_aa998eef",
      "range": {
        "startLine": 1915,
        "startChar": 5,
        "endLine": 1915,
        "endChar": 9
      },
      "revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "8c56d288_c8eb0163",
        "filename": "mtce-common/src/common/nodeUtil.cpp",
        "patchSetId": 7
      },
      "lineNbr": 1915,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-03-28T21:28:53Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "fb535e02_d4964feb",
      "range": {
        "startLine": 1915,
        "startChar": 5,
        "endLine": 1915,
        "endChar": 9
      },
      "revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "380579a7_e20258f2",
        "filename": "mtce/src/common/nodeClass.cpp",
        "patchSetId": 7
      },
      "lineNbr": 3553,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-03-26T13:26:17Z",
      "side": 1,
      "message": "filestream.close() ?",
      "revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ca6f4423_0093f950",
        "filename": "mtce/src/common/nodeClass.cpp",
        "patchSetId": 7
      },
      "lineNbr": 3553,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-03-28T12:16:38Z",
      "side": 1,
      "message": "Yes, good one. Will update.",
      "parentUuid": "380579a7_e20258f2",
      "revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "c9cb0163_4634f26b",
        "filename": "mtce/src/common/nodeClass.cpp",
        "patchSetId": 7
      },
      "lineNbr": 3553,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-03-28T21:28:53Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "ca6f4423_0093f950",
      "revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}