Add consistent init and config complete checks to collectd plugins

Some of the collectd plugins are not waiting for configuration
complete before starting to monitor or communicate with external
services such as fm. This leads to the collectd networking plugin
being triggered to run before or while the host is being configured
which has been seen to lead to collectd segfaults/coredumps within
the collectd's internal networking plugin.

To solve this issue, reduce startup thrash and a slew of plugin
startup error logs, this update adds consistent initialization
and configuration complete checks to all of the starlingX
plugins so monitoring and external service access is not
performed until the host configuration is complete.

Test Plan:

PASS: Verify no plugin sampling till after config is complete
PASS: Verify alarm assert and clear cycle for all plugins
PASS: Install AIO SX system install
PASS: Install AIO DX system install
PEND: Verify Standard system install
PASS: Verify logging

Change-Id: I90a5d1c8c3be77269a571738c9499b2e908e1fc5
Closes-Bug: 1872979
Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>

collectd-extensions/src/remotels.py

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2019 Wind River Systems, Inc.
+# Copyright (c) 2019-2020 Wind River Systems, Inc.
 #
 # SPDX-License-Identifier: Apache-2.0
 #
@@ -146,15 +146,14 @@ def init_func():
     if tsc.nodetype != 'controller':
         return 0
 
-    if obj.init_done is False:
-        if obj.init_ready() is False:
-            return False
+    # do nothing till config is complete.
+    if obj.config_complete() is False:
+        return 0
 
     obj.hostname = obj.gethostname()
     obj.base_eid = 'host=' + obj.hostname
-    obj.init_done = True
-    collectd.info("%s initialization complete" % PLUGIN)
 
+    obj.init_completed()
     return True
 
 
@@ -166,7 +165,7 @@ def read_func():
     if tsc.nodetype != 'controller':
         return 0
 
-    if obj.init_done is False:
+    if obj.init_complete is False:
         init_func()
         return 0