From 2c40be676e7c60431560a003a58f30de428af103 Mon Sep 17 00:00:00 2001 From: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 15 Apr 2024 13:44:40 +0000 Subject: [PATCH] Update patch set 13 Patch Set 13: Code-Review+1 (4 comments) Patch-set: 13 Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1, 464b251b423b3079d9e6a50687b7f31b7d42dfec Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"} --- 94ec121a6a89733b90554cc318c2e6bb2f00caef | 96 ++++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 94ec121a6a89733b90554cc318c2e6bb2f00caef diff --git a/94ec121a6a89733b90554cc318c2e6bb2f00caef b/94ec121a6a89733b90554cc318c2e6bb2f00caef new file mode 100644 index 00000000..cc739c33 --- /dev/null +++ b/94ec121a6a89733b90554cc318c2e6bb2f00caef @@ -0,0 +1,96 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "4364c363_c5854f8d", + "filename": "nfv/nfv-vim/nfv_vim/directors/_host_director.py", + "patchSetId": 13 + }, + "lineNbr": 697, + "author": { + "id": 28464 + }, + "writtenOn": "2024-04-15T13:44:40Z", + "side": 1, + "message": "USM allows the upgrade of an unlocked enable host ?", + "range": { + "startLine": 696, + "startChar": 12, + "endLine": 697, + "endChar": 57 + }, + "revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "54a99c38_d1777447", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py", + "patchSetId": 13 + }, + "lineNbr": 1264, + "author": { + "id": 28464 + }, + "writtenOn": "2024-04-15T13:44:40Z", + "side": 1, + "message": "Not clear why \u0027instances\u0027 and not \u0027instance_list\u0027 since instances is not in context here. Also why add the comment but not make and test the change ?", + "range": { + "startLine": 1263, + "startChar": 20, + "endLine": 1264, + "endChar": 66 + }, + "revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "49c5068e_88399661", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py", + "patchSetId": 13 + }, + "lineNbr": 1809, + "author": { + "id": 28464 + }, + "writtenOn": "2024-04-15T13:44:40Z", + "side": 1, + "message": "nit: spelling - \u0027certain\u0027", + "range": { + "startLine": 1809, + "startChar": 19, + "endLine": 1809, + "endChar": 28 + }, + "revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "043980f2_e9bcd7c5", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py", + "patchSetId": 13 + }, + "lineNbr": 1916, + "author": { + "id": 28464 + }, + "writtenOn": "2024-04-15T13:44:40Z", + "side": 1, + "message": "not: comment should read \u0027unlock/enabled/available\u0027 not online based on the check below.", + "range": { + "startLine": 1916, + "startChar": 51, + "endLine": 1916, + "endChar": 57 + }, + "revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file