Propagate unexpected errors from nfv client

The code that was iterating over unexpected errors would
accidentally 'return' rather than raise the error during
the area where it extracts a reason from the exception.

This meant that if the API returned an internal error (500)
the code would mistakenly treat the result as a None response.

This was particularly troublesome when performing GET operations.

Now it reports the error and allows the exception to be raised.

Test Plan:
  PASS: Verify the CLI reports an error when invoked while the API
is beng restarted.
  PASS: Verify the CLI returns a valid value when invoked under
normal circumstances.
  PASS: Verify the API reports an error rather than None when a
strategy is queried during an API restart.

Closes-Bug: 1950207
Signed-off-by: albailey <Al.Bailey@windriver.com>
Change-Id: I7dc62b28425f09edabf2e6e4914aebc013da3cf4
This commit is contained in:
albailey 2021-11-08 15:50:21 -06:00
parent eed8e0ba80
commit 515c22944d
1 changed files with 1 additions and 1 deletions

View File

@ -91,7 +91,7 @@ def request(token_id, method, api_cmd, api_cmd_headers=None,
if message is not None:
reason = str(message.rstrip('.'))
print("Operation failed: %s" % reason)
return
break
except ValueError:
pass