starlingx
/
nfv
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review-1

(5 comments)

Patch-set: 10
Reviewer: Gerrit User 9926 <9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 689fccc5e052ebd91dc027c3a88d5f971d3a6c1a
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-04-08 12:52:40 +00:00 committed by Gerrit Code Review
parent fb64fd7c7e
commit 57ef304f6d
2 changed files with 93 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
42bd0bacf2a83108d50adc7feb000410012bafd2 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "2b828b91_78096512",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 10
},
"lineNbr": 2167,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "this else (line 2166) will result in nfvi_alarm always being appended even when _ignore_alarms_conditional[] condition isnt being met ?",
"revId": "42bd0bacf2a83108d50adc7feb000410012bafd2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

72
9f8096d129750ad3e244ea668f16496db05a1d1a
View File

@ -17,6 +17,24 @@
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a58b25fd_3e11b029",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 9,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "pending update",
"parentUuid": "022c417f_478ac200",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -121,6 +139,24 @@
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4a77d454_7be8d5a7",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2162,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "shouldnt this alarm only be ignored if less than 30mins?",
"parentUuid": "2557ca3f_399e3aed",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -138,6 +174,24 @@
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "60bb5074_d0ea55e5",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2165,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "this will only index 1st item in dictionary.\n\nConsider self._ignore_alarms_append(nfvi_alarm.alarm_id) ...",
"parentUuid": "ee3886d2_b9bf4b62",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -154,6 +208,24 @@
"message": "code also needs update for generic case (as per comment above)",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e19db8c2_0567f2ae",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2179,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "this will only check the first key of dictionary. Also shouldn\u0027t this condition depend on whether the time has expired?\n\nConsider:\n\n if alarm[\u0027alarm_id\u0027] in self._ignore_alarms:\n self.strategy.nfvi_alarms.remove(alarm)",
"parentUuid": "5f8187d7_56d038dd",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}