From 68b1c3bb2bde44d915ad2422930e409d2c4e3706 Mon Sep 17 00:00:00 2001
From: Gerrit User 21776 <21776@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Thu, 25 Aug 2022 19:55:51 +0000
Subject: [PATCH] Update patch set 4

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_21776\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 21776 \u003c21776@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_21776\u003e replied on the change"}
---
 eac89686e2ff31f2e5a8e3b529a469f90cc9f990 | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/eac89686e2ff31f2e5a8e3b529a469f90cc9f990 b/eac89686e2ff31f2e5a8e3b529a469f90cc9f990
index a5d21f8d..65024f3c 100644
--- a/eac89686e2ff31f2e5a8e3b529a469f90cc9f990
+++ b/eac89686e2ff31f2e5a8e3b529a469f90cc9f990
@@ -70,6 +70,30 @@
       },
       "revId": "eac89686e2ff31f2e5a8e3b529a469f90cc9f990",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "322e7d45_8567beb3",
+        "filename": "nfv/nfv-vim/nfv_vim/api/acl/policies/sw_update_strategy_policy.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 26,
+      "author": {
+        "id": 21776
+      },
+      "writtenOn": "2022-08-25T19:55:51Z",
+      "side": 1,
+      "message": "I added a comment.\nI\u0027ve tested the patch strategy create, delete, show, apply, and abort, and ensured it gets through my changes (admin is allowed on all, reader allowed on show). I don\u0027t think testing the apply completely is needed, since that part of the code was not changed. It would also not be fair to not test the other commands like fw_update, kube_upgrade, kube_rootca_update, sw_patch_strategy. Lots of testing overhead for behavior that was not changed by this commit.",
+      "parentUuid": "da396c6e_f0d11cc3",
+      "range": {
+        "startLine": 26,
+        "startChar": 21,
+        "endLine": 26,
+        "endChar": 27
+      },
+      "revId": "eac89686e2ff31f2e5a8e3b529a469f90cc9f990",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file