starlingx/nfv
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-04-22 16:06:08 +00:00 committed by Gerrit Code Review
parent 3282ebc24f
commit ec7927464f
1 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
748c9090fe85301cc32cf25d7830eddc8b15b7aa Normal file
View File

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e8ead83e_48e88f08",
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
"patchSetId": 2
},
"lineNbr": 60,
"author": {
"id": 9926
},
"writtenOn": "2024-04-22T16:06:08Z",
"side": 1,
"message": "a TODO should be added to reduce this when the software-api is async for patch release",
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "be1ad2f8_db2c916f",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/usm.py",
"patchSetId": 2
},
"lineNbr": 91,
"author": {
"id": 9926
},
"writtenOn": "2024-04-22T16:06:08Z",
"side": 1,
"message": "the region_name is a variable, so cannot assume a region_name\n\nPlease verify with subcloud deployment; and/or this review https://review.opendev.org/c/starlingx/ansible-playbooks/+/916310 and it\u0027s 3 Depends-On dependencies",
"range": {
"startLine": 91,
"startChar": 44,
"endLine": 91,
"endChar": 67
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}