starlingx
/
nfv
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(13 comments)

Patch-set: 12
Reviewer: Gerrit User 9926 <9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 35748 <35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 35148 \u003c35148@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35148\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35148\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35148\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35148\u003e replied on the change"}
This commit is contained in:
Gerrit User 35148 2024-04-09 13:49:48 +00:00 committed by Gerrit Code Review
parent 370af3bc60
commit eca9e40e50
2 changed files with 288 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
00cc55cb0b460465247074aa916817bc9ded9367
View File

@ -22,6 +22,30 @@
},
"revId": "00cc55cb0b460465247074aa916817bc9ded9367",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e8bab1d1_b8844857",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 10
},
"lineNbr": 2243,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Done",
"parentUuid": "9a92f05e_d6f993f5",
"range": {
"startLine": 2243,
"startChar": 32,
"endLine": 2243,
"endChar": 34
},
"revId": "00cc55cb0b460465247074aa916817bc9ded9367",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

264
a10f01e8e9502a6d193bb65bafb541ad7e70f3c6
View File

@ -23,6 +23,30 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6b194477_e1d9c3d1",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 11
},
"lineNbr": 2277,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Done",
"parentUuid": "e6f07efa_3ce603c0",
"range": {
"startLine": 2277,
"startChar": 23,
"endLine": 2277,
"endChar": 33
},
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f9aeab03_ea5dfb47",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 11
},
"lineNbr": 2321,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Updated. But also note, the comment/errors do not match function names because they are not implemented for USM yet.",
"parentUuid": "1d03a0d8_8740e929",
"range": {
"startLine": 2321,
"startChar": 36,
"endLine": 2321,
"endChar": 39
},
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "569a1825_8309b040",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 11
},
"lineNbr": 2333,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Done",
"parentUuid": "45711420_57ca719c",
"range": {
"startLine": 2333,
"startChar": 20,
"endLine": 2333,
"endChar": 29
},
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -92,6 +164,30 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b40eabdc_c0b9f239",
"filename": "nfv/nfv-tests/nfv_unit_tests/tests/test_nfv_client.py",
"patchSetId": 11
},
"lineNbr": 256,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Done",
"parentUuid": "b9f0cd0a_d653e969",
"range": {
"startLine": 256,
"startChar": 17,
"endLine": 256,
"endChar": 27
},
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -109,6 +205,24 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fae2273f_02d7aa63",
"filename": "nfv/nfv-vim/nfv_vim/directors/_host_director.py",
"patchSetId": 11
},
"lineNbr": 696,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Probably not comment worthy. This is the default behavior for directors, were as before it was doing something unique and should have been commented.",
"parentUuid": "5aab212b_85743b9e",
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -132,6 +246,30 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ec800f36_bae3c163",
"filename": "nfv/nfv-vim/nfv_vim/directors/_sw_mgmt_director.py",
"patchSetId": 11
},
"lineNbr": 78,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Done",
"parentUuid": "d445888a_3a7a01df",
"range": {
"startLine": 78,
"startChar": 35,
"endLine": 78,
"endChar": 51
},
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -155,6 +293,30 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fb830f00_4df2d149",
"filename": "nfv/nfv-vim/nfv_vim/directors/_sw_mgmt_director.py",
"patchSetId": 11
},
"lineNbr": 95,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Done",
"parentUuid": "5c15363b_817bd8c0",
"range": {
"startLine": 95,
"startChar": 27,
"endLine": 95,
"endChar": 43
},
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -178,6 +340,30 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4e0679bf_76b82b25",
"filename": "nfv/nfv-vim/nfv_vim/nfvi/_nfvi_infrastructure_module.py",
"patchSetId": 11
},
"lineNbr": 382,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Done",
"parentUuid": "683afcbf_8a972287",
"range": {
"startLine": 382,
"startChar": 4,
"endLine": 382,
"endChar": 17
},
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -213,6 +399,24 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1acfbb83_53a5e3a2",
"filename": "nfv/nfv-vim/nfv_vim/nfvi/objects/v1/_upgrade.py",
"patchSetId": 11
},
"lineNbr": 14,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "Will change after finalized.",
"parentUuid": "707e043a_004ef371",
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -230,6 +434,24 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "355e9ee9_518806b7",
"filename": "nfv/nfv-vim/nfv_vim/nfvi/objects/v1/_upgrade.py",
"patchSetId": 11
},
"lineNbr": 43,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "TODO",
"parentUuid": "faad15e4_8d974da8",
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -253,6 +475,30 @@
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fae3fe04_f90345c3",
"filename": "nfv/nfv-vim/nfv_vim/nfvi/objects/v1/_upgrade.py",
"patchSetId": 11
},
"lineNbr": 96,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "At the time of this, USM states represent current completed not in progress.\n\nThis may change in follow up if needed.",
"parentUuid": "773364b6_bf6d85c2",
"range": {
"startLine": 96,
"startChar": 8,
"endLine": 96,
"endChar": 20
},
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -269,6 +515,24 @@
"message": "this may not guarantee that controller-1 is first; the id order in the database may change if a host-delete occurred (e.g. to change /replace hardware) previously",
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "52f4abdd_4bf5d5b7",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 11
},
"lineNbr": 1974,
"author": {
"id": 35148
},
"writtenOn": "2024-04-09T13:49:48Z",
"side": 1,
"message": "This was just to get unit tests passing. Will need to be refined when major released is supported.",
"parentUuid": "61c29b78_6de1c08a",
"revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}