nfv/3a239df1a666191d38475d6041d29d6548eea227

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "9677d371_667a9c9b",
        "filename": "/COMMIT_MSG",
        "patchSetId": 1
      },
      "lineNbr": 7,
      "author": {
        "id": 28715
      },
      "writtenOn": "2024-03-13T19:02:48Z",
      "side": 1,
      "message": "\u0027in nfv\u0027 redundant, this is NFV repo\n\nJust be specific, eg\nIncrease timeout for KubeHostUpgradeControlPlaneStep to 540s",
      "range": {
        "startLine": 7,
        "startChar": 53,
        "endLine": 7,
        "endChar": 59
      },
      "revId": "3a239df1a666191d38475d6041d29d6548eea227",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c400f67a_e1201b22",
        "filename": "/COMMIT_MSG",
        "patchSetId": 1
      },
      "lineNbr": 15,
      "author": {
        "id": 28715
      },
      "writtenOn": "2024-03-13T19:02:48Z",
      "side": 1,
      "message": "This update increases KubeHostUpgradeControlPlaneStep timeout to 540s. This is intentionally engineered to be larger than the resultant time for sysinv code to reach completion of the Kubernetes Upgrade control-plane step with retries and accounting for failure.\n\nThe timeout is engineered using the following equation. This accounts for retries, hitting kubeadm upgrade timeout each try, and some buffer for the sysinv report callback mechanism.\n\nnfv_timeout \u003d ImageDownloadTime + retries*(UpgradeControlPlaneTimeout + buffer)\n\nUse the following engineered parameters:\n- ImageDownloadTime \u003d 0s (images are pre-pull before this step)\n- UpgradeManifestTimeout \u003d 4 minutes\n- buffer \u003d 30s\n- 2 retries\n\nPerform engineering rounding of the value to give additional buffer.\n\nResult:\nEngineered puppet timeout for upgrade control-plane:\n\u003d UpgradeControlPlaneTimeout + buffer \u003d 4*60s + 30s \u003d 270s\n\nEngineered NFV timeout:\n\u003d 0s + 2*(4*60s + 30s) \u003d 540s",
      "range": {
        "startLine": 9,
        "startChar": 0,
        "endLine": 15,
        "endChar": 25
      },
      "revId": "3a239df1a666191d38475d6041d29d6548eea227",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "b9ee5e94_fecff848",
        "filename": "/COMMIT_MSG",
        "patchSetId": 1
      },
      "lineNbr": 16,
      "author": {
        "id": 28715
      },
      "writtenOn": "2024-03-14T14:27:20Z",
      "side": 1,
      "message": "Add LP/Story, make consistent topic with the other reviews",
      "revId": "3a239df1a666191d38475d6041d29d6548eea227",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c0a34cff_a0ad891a",
        "filename": "/COMMIT_MSG",
        "patchSetId": 1
      },
      "lineNbr": 21,
      "author": {
        "id": 28715
      },
      "writtenOn": "2024-03-13T19:02:48Z",
      "side": 1,
      "message": "Add TC for orchestrated k8s upgrade without hitting timeout.",
      "revId": "3a239df1a666191d38475d6041d29d6548eea227",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "3094df96_0d78d679",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 28715
      },
      "writtenOn": "2024-03-13T19:02:48Z",
      "side": 1,
      "message": "Need Vanathi to confirm that the image download step is excluded from this control-plane upgrade step.",
      "revId": "3a239df1a666191d38475d6041d29d6548eea227",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e99b1288_5e3c4df1",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 35748
      },
      "writtenOn": "2024-03-13T19:40:35Z",
      "side": 1,
      "message": "There is no image download step done as part of control-plane upgrade step.",
      "parentUuid": "3094df96_0d78d679",
      "revId": "3a239df1a666191d38475d6041d29d6548eea227",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1f731171_0b216f0e",
        "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
        "patchSetId": 1
      },
      "lineNbr": 4714,
      "author": {
        "id": 35748
      },
      "writtenOn": "2024-03-13T19:40:35Z",
      "side": 1,
      "message": "Add TC - k8s upgrade where nfv timeout is hit, after puppet timeout.\nThis is mainly needed to see if the stage level or phase level\ntimeouts of VIM has impacts.",
      "revId": "3a239df1a666191d38475d6041d29d6548eea227",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}