starlingx
/
nfv
Code Issues Proposed changes
nfv/9f8096d129750ad3e244ea668f1...

321 lines
9.2 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "022c417f_478ac200",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 9,
"author": {
"id": 9926
},
"writtenOn": "2024-04-05T22:56:10Z",
"side": 1,
"message": "should also include the generic approach developed",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a58b25fd_3e11b029",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 9,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "pending update",
"parentUuid": "022c417f_478ac200",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8bc59a3a_51be25aa",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 9,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "a58b25fd_3e11b029",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "45b986c2_1403f3f6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 9926
},
"writtenOn": "2024-04-05T22:56:10Z",
"side": 1,
"message": "recheck",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "436717b3_b1a3bb34",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 4
},
"lineNbr": 1400,
"author": {
"id": 9926
},
"writtenOn": "2024-04-05T22:56:10Z",
"side": 1,
"message": "750.006?",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "10adbd71_d0eefb7b",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 4
},
"lineNbr": 1400,
"author": {
"id": 35748
},
"writtenOn": "2024-04-08T04:09:09Z",
"side": 1,
"message": "Done",
"parentUuid": "436717b3_b1a3bb34",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "da3d8f59_312f19a5",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 1921,
"author": {
"id": 9926
},
"writtenOn": "2024-04-05T22:56:10Z",
"side": 1,
"message": "Extra space at end of line",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e2ff783d_a2d0c60a",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 1921,
"author": {
"id": 35748
},
"writtenOn": "2024-04-08T04:09:09Z",
"side": 1,
"message": "Done",
"parentUuid": "da3d8f59_312f19a5",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2557ca3f_399e3aed",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2162,
"author": {
"id": 9926
},
"writtenOn": "2024-04-05T22:56:10Z",
"side": 1,
"message": "this comment should be more generic",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4a77d454_7be8d5a7",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2162,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "shouldnt this alarm only be ignored if less than 30mins?",
"parentUuid": "2557ca3f_399e3aed",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "97a7602d_3051442f",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2162,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T21:34:03Z",
"side": 1,
"message": "actually, it appears the intent of the original review is wait until 750.006 alarm is cleared or becomes stale and then continue",
"parentUuid": "4a77d454_7be8d5a7",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cf3fc233_82734406",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2162,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "97a7602d_3051442f",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ee3886d2_b9bf4b62",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2165,
"author": {
"id": 9926
},
"writtenOn": "2024-04-05T22:56:10Z",
"side": 1,
"message": "this should append this specific alarm id",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "60bb5074_d0ea55e5",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2165,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "this will only index 1st item in dictionary.\n\nConsider self._ignore_alarms_append(nfvi_alarm.alarm_id) ...",
"parentUuid": "ee3886d2_b9bf4b62",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "976dc334_e3e4f9eb",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2165,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "60bb5074_d0ea55e5",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5f8187d7_56d038dd",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2179,
"author": {
"id": 9926
},
"writtenOn": "2024-04-05T23:24:09Z",
"side": 1,
"message": "code also needs update for generic case (as per comment above)",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e19db8c2_0567f2ae",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2179,
"author": {
"id": 9926
},
"writtenOn": "2024-04-08T12:52:40Z",
"side": 1,
"message": "this will only check the first key of dictionary. Also shouldn\u0027t this condition depend on whether the time has expired?\n\nConsider:\n\n if alarm[\u0027alarm_id\u0027] in self._ignore_alarms:\n self.strategy.nfvi_alarms.remove(alarm)",
"parentUuid": "5f8187d7_56d038dd",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6ba1777c_f1a7eb01",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2179,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "e19db8c2_0567f2ae",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink