141 lines
4.1 KiB
Plaintext
141 lines
4.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e27b8431_aa417bf7",
|
|
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 996,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-10T13:52:12Z",
|
|
"side": 1,
|
|
"message": "recommend use of constant instead so these are easier to identify in future; several instances in this file",
|
|
"range": {
|
|
"startLine": 996,
|
|
"startChar": 59,
|
|
"endLine": 996,
|
|
"endChar": 66
|
|
},
|
|
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d4040f29_be4827ec",
|
|
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 1407,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-10T13:52:12Z",
|
|
"side": 1,
|
|
"message": "not necessarily only, as may be used for other orchestrators in future",
|
|
"range": {
|
|
"startLine": 1407,
|
|
"startChar": 18,
|
|
"endLine": 1407,
|
|
"endChar": 23
|
|
},
|
|
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f0f610a3_5203af71",
|
|
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 1922,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-10T13:52:12Z",
|
|
"side": 1,
|
|
"message": "this is for ignoring each alarm up to specified amount of time. (i.e. generic, though currently used for patch strategy)",
|
|
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e5b29c3d_bd901640",
|
|
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 2154,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-10T13:52:12Z",
|
|
"side": 1,
|
|
"message": "comment should be more generic",
|
|
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c41343c5_fbb8d23b",
|
|
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 2163,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-10T13:52:12Z",
|
|
"side": 1,
|
|
"message": "comment should be more generic",
|
|
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8eeda8bd_fb7af7ea",
|
|
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 2165,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-10T13:52:12Z",
|
|
"side": 1,
|
|
"message": "shouldnt this just ignore the alarm that met the condition at 2164 rather than all elements of self._ignore_alarms_conditional ?",
|
|
"range": {
|
|
"startLine": 2165,
|
|
"startChar": 52,
|
|
"endLine": 2165,
|
|
"endChar": 96
|
|
},
|
|
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4b125f82_7289c3fe",
|
|
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 2181,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-10T13:52:12Z",
|
|
"side": 1,
|
|
"message": "comment on the purpose of this code block. It appears to be unconditionally removing all _ignore_alarms_condition which doesnt appear correct",
|
|
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |