starlingx
/
openstack-armada-app
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(1 comment)

Patch-set: 5
Reviewer: Gerrit User 32349 <32349@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 32349 \u003c32349@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32349\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33987 \u003c33987@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32349\u003e replied on the change"}
This commit is contained in:
Gerrit User 32349 2022-08-04 17:05:46 +00:00 committed by Gerrit Code Review
parent 38f01fe7e7
commit 0559f4fd0f
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
3dbfd56429a51d9b92cd5d284f10f2d6d70d9b2d Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "ae149bad_23e1d967",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 32349
},
"writtenOn": "2022-08-04T17:05:46Z",
"side": 1,
"message": "This has a strong depends-on on Thales\u0027 patch now. If this one merges before his, it\u0027ll break the application. I suggest doing at least the armada manifest overrides along with this patch so it can be merged independently.",
"revId": "3dbfd56429a51d9b92cd5d284f10f2d6d70d9b2d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}